-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the release process/CI #15
Comments
This makes sure that executable flags are preserved, but it also makes sure the version number is in the filename.
They seem unmaintained now, which will be an issue with https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12
I've made some of the required changes (see the checklist in the initial issue), but I'll postpone some others, mainly the "maintainer comfort" things. GitHub Actions isn't my favorite CI, and I feel like to comfortably do this without too many hacks, I'd need to invent my own action(s). This isn't needed for a 1.0.0 release, so I'll unblock the release. |
Clearly, the world isn't ready for libraries that new yet.
I'm currently too lazy to address any of the remaining issues, mainly because I don't have a need for now. |
There are a couple of things I could improve.
upload-artifact
action, but this can be worked around by building atar
/zip
manually and uploading that.camo-linux-amd64.zip
, it probably makes sense to add the version number to the archive, something likecamo-v0.3.0-linux-amd64.zip
so it's clear when linking to it.build
job for therelease
branch is done, then downloading the artifacts, drafting a release, and attaching the artifacts there. In theory, I could run GHA when a new tag is created, build release artifacts, and automatically create a new draft release with the artifacts attached. Thematrix-org/synapse
repo has something close to that where I could probably take inspiration from.::set-output
are deprecated, and there is a much nicer way available.action-rs
seems unmaintained. This will become an issue soon since GitHub Actions will deprecate NodeJS 12. I can probably just manually userustup
and callcargo
...Optionally, some other things:
docker-release
workflow currently doesn't care about the "pre-release" checkbox in a release, and would tag even pre-releases tolatest
. This probably isn't a big deal since I don't plan on releasing pre-releases, but it might be worth adjusting that, and only push a tag1.0.0-dev
, instead of pushing it to1
,1.0
,1.0.0-dev
, andlatest
.The text was updated successfully, but these errors were encountered: