Skip to content

Commit

Permalink
[core] [9/N] Skip installation if already (ray-project#48731)
Browse files Browse the repository at this point in the history
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
  • Loading branch information
dentiny committed Dec 7, 2024
1 parent 248a7a3 commit 8d25c9e
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions python/ray/_private/runtime_env/uv.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def _get_uv_exec_to_install() -> str:
"install",
"--disable-pip-version-check",
"--no-cache-dir",
"--force-reinstall",
_get_uv_exec_to_install(),
]
logger.info("Installing package uv to %s", virtualenv_path)
Expand Down Expand Up @@ -154,11 +153,6 @@ async def _install_uv_packages(
uv_exists = await self._check_uv_existence(python, cwd, pip_env, logger)

# Install uv, which acts as the default package manager.
#
# TODO(hjiang): If `uv` in virtual env perfectly matches the version users
# require, we don't need to install also. It requires a different
# implementation to execute and check existence. Here we take the simpliest
# implementation, always reinstall the required version.
if (not uv_exists) or (self._uv_config.get("uv_version", None) is not None):
await self._install_uv(path, cwd, pip_env, logger)

Expand Down

0 comments on commit 8d25c9e

Please sign in to comment.