Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling should dismiss image or be locked #47

Closed
tobimori opened this issue Jun 26, 2023 · 0 comments · Fixed by #48
Closed

Scrolling should dismiss image or be locked #47

tobimori opened this issue Jun 26, 2023 · 0 comments · Fixed by #48
Assignees
@deoostfrees
Labels
type: enhancement New feature or request
Milestone
2.4.0

Comments

@tobimori
Copy link

tobimori commented Jun 26, 2023 •
edited
Loading

Current behaviour - based on the CodePen example:
Opening a gallery does not stop scrolling. The user can dismiss the image via touch (or dragging).

Desired behaviour:
a.) Scrolling would dismiss the image, similiar to https://github.com/francoischalifour/medium-zoom
b.) Scrolling would be locked if a Parvus lightbox is open
@deoostfrees deoostfrees self-assigned this Jul 4, 2023
@deoostfrees deoostfrees added the type: enhancement New feature or request label Jul 4, 2023
deoostfrees added a commit that referenced this issue Jul 4, 2023
@deoostfrees
[FEATURE] Add option to hide the browser scrollbar
2bd13f8 
Related: #47
@deoostfrees deoostfrees added this to the 2.4.0 milestone Jul 4, 2023
@deoostfrees deoostfrees linked a pull request Jul 7, 2023 that will close this issue
2.4.0 #48
Merged
deoostfrees added a commit that referenced this issue Jul 20, 2023
@deoostfrees
[FEATURE] Add option to hide the browser scrollbar
4d102ec 
Related: #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deoostfrees deoostfrees

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

2.4.0 deoostfrees/Parvus
2 participants
@tobimori @deoostfrees