LEAF 4626 - Form Editor drag-drop fix for Firefox browser, CSS fixes #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fix to drag drop behavior for Firefox browser. Minor html updates to form browser table and its img elements.
aerinkayne
requested review from
mgaoVA,
pete-nerantzinis,
Pelentan,
shaneodd,
jampaul3 and
nk2136
shaneodd
approved these changes
Jan 2, 2025
aerinkayne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix to drag drop behavior for Firefox browser.
Expression fix is a recommendation from online sources to address issues with a long-standing Firefox bug. It is mostly taken as-is and only runs if the Form Editor is created when using Firefox.
Other (uncovered during update)
Add CSS specificity fix for form li elements intended for drag-drop to address unintended styling of lists in question names and form questions that are in preview mode.
HTML update to form browser tables (add explicit thead and tbody) and one of its img elements (add explicit height) to address console warnings.
Impact / Testing
Form Editor Drag-Drop functionality, Firefox Browser.
Form Editor Drag-Drop should work as expected when using Firefox.
Other
Form Editor related tests pass.
Form Editor
-Lists in question names display as expected on form Editing and Preview modes
-Form Questions display as expected in preview mode