feature/APPEALS-57706: Establishment of a Prioritized National Hearing Queue #23416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit. Adding in gem into gem file * making gemfile alphabetical --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com>
* APPEALS-59219 Updating oracle_fdw setup script with notes * APPEALS-59219 Addressing PR feedback
…iew (#23192) * initial push to stash * initial push * fixing code climate things * adding migration * removing oracle_fdw extension * rubocop * rspec * rubocop'n * adding comments and changing variable names * removing oracle_fdw * adding migrations * removing oracle_fdw from schema * Update db/views/national_hearing_queue_entries_v01.sql Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * Update db/migrate/20241008145227_create_national_hearing_queue_entries.rb Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * Update app/models/national_hearing_queue_entry.rb Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * editing sql to account for ScheduledHearingTasks and removing stuff from schema * fixing sql * removing extra end * adding matt's things * removing remand --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
* APPEALS-59235 Add foreign tables for VACOLS * APPEALS-59235 Add STAFF and ASSIGN foreign tables for VACOLS
…nition to Include Legacy Appeal Information (#23335) * initial commit * Add postgres container steps * Pull ECR image * Revert postgres service name * Install psql * Fix commands being out of order * Revert POSTGRES_HOST * Update another missed host shift * Fix syntax issue * Create test version of foreign table script * Separate db creation and loading the schema * Fix over-erasure of command * Remove byebug * initial push * removing binding.pry * rubocop * rubocop * addressing Matt's comments * rubocopn * rubocop * addressing matt's comments * adding new test to ensure formatting of the view * rubocop * rubocop --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* initial commit * Add postgres container steps * Pull ECR image * Revert postgres service name * Install psql * Fix commands being out of order * Revert POSTGRES_HOST * Update another missed host shift * Fix syntax issue * Create test version of foreign table script * Separate db creation and loading the schema * Fix over-erasure of command * Remove byebug * initial push * removing binding.pry * rubocop * rubocop * addressing Matt's comments * rubocopn * Pushing current changes for APPEALS-59241 * Adjiust legacy AOD logic * Flip age conditionals * Account for ALL claimants in AMA query * Add helpful comment * Remove unrecognized appellant for AOD * Tab over a few lines * Rename migration file * Add materialized: true to migration * Scope previous tests to just appeals columns * APPEALS-59243 created script for adding schedulable field * APPEALS-59243 sql script has schedulable field included * APPEALS-59243 wrote rspec tests * APPEALS-59243 adjusted a spec test * APPEALS-59243 new migration --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Prerna Devulapalli <132498915+prernadevbah@users.noreply.github.com>
…ies Materialized View (#23382) * initial commit * Add postgres container steps * Pull ECR image * Revert postgres service name * Install psql * Fix commands being out of order * Revert POSTGRES_HOST * Update another missed host shift * Fix syntax issue * Create test version of foreign table script * Separate db creation and loading the schema * Fix over-erasure of command * Remove byebug * initial push * removing binding.pry * rubocop * rubocop * addressing Matt's comments * rubocopn * Pushing current changes for APPEALS-59241 * Adjiust legacy AOD logic * Flip age conditionals * Account for ALL claimants in AMA query * Add helpful comment * Remove unrecognized appellant for AOD * Tab over a few lines * Rename migration file * Add materialized: true to migration * Scope previous tests to just appeals columns * Add AMA aod_indicator specs * Add legacy specs * Test rekickoff * Remove extraneous schema entries * Oops, to ofar * Update PR template * Empty commit to kick off tests * Add sadvage condition for legacy AOD * Remove savdage for now * Going ahead and adding the belong_to for the ScheduleHearingTasks * Update varchar sizes to match what was in PreProd just now * Remove extra pieces * Add back in the refresh * Lint fix * Try to scope cleanups to only test cases with legacy appeals * Another lint fix * Shifting test order * Lint fixes --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: Prerna Devulapalli <132498915+prernadevbah@users.noreply.github.com>
|
Code Climate has analyzed commit 547977b and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
- spec/feature/hearings/virtual_hearings/daily_docket_spec.rb - spec/models/hearings/forms/hearing_update_form_spec.rb
* APPEALS-59455 add new fields for associated task * APPEALS-59455 adjusted rspec tests * APPEALS-59455 fixed broken tests * APPEALS-59455 removed vbms_ext_claim table from schema * APPEALS-59455 adjusted days_waiting and days_on_hold sql query * APPEALS-59455 adjusted rspec tests --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
…national_hearing_queue_entries Materialized View (#23424) * initial commit * rubocop'n * adding to scheduled_jobs * editing tests * rubocop * trying to fix tests * reverting * addressing timeout comment from matt * fixing tests * Remove after(:each) for testing (#23442) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * rubocop * removing lines * pushing up matt's changes * 🔥 Remove commented out code * making tests green * rubocop * rubocop --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* ➕ Add fx gem * Add gather_vacols_ids_of_hearing_schedulable_legacy_appeals function * Add a spec test * Lint roll --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* APPEALS-63928 created new schedulable_cutoff_date model * APPEALS-63928 made rspec tests * APPEALS-63928 adjusted schema * APPEALS-63928 adjusted schema * APPEALS-63928 adjusted factory, spec, and model --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
…vacols_brieff Records Given a String Containing vacols_ids (#23484) * ➕ Add fx gem * Add gather_vacols_ids_of_hearing_schedulable_legacy_appeals function * Add a spec test * Lint roll * Add a user-defined brieff_record PG type * Add brieffs_awaiting_hearing_scheduling function * Update type in custom type * Add brieffs_awaiting_hearing_scheduling spec file * Update db/functions/brieffs_awaiting_hearing_scheduling_v01.sql * Update db/schema.rb * Add custom type creation to CI pipeline * Switch to using .fields * Fix test name * Add nullcheck to function to prevent errors --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
…ings PostgreSQL Data Store (#23473) * APPEALS-59240 Adding job to check veteran residence location * APPEALS-59240 Adding tests, Addressing lint issues * APPEALS-59240 Fix schema * APPEALS-59240 Addressing PR feedback and adding tests * APPEALS-59240 Adding tests * APPEALS-59240 Address feedback and edge cases * APPEALS-59240 Cleaning up generator and tests --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
…Legacy Appeals with Active ScheduleHearingTasks (#23508) * ➕ Add fx gem * Add gather_vacols_ids_of_hearing_schedulable_legacy_appeals function * Add a spec test * Lint roll * Add a user-defined brieff_record PG type * Add brieffs_awaiting_hearing_scheduling function * Update type in custom type * Add brieffs_awaiting_hearing_scheduling spec file * Update db/functions/brieffs_awaiting_hearing_scheduling_v01.sql * Update db/schema.rb * Add custom type creation to CI pipeline * Switch to using .fields * Fix test name * Add gather_bfcorkeys_of_hearing_schedulable_legacy_cases function * Migrate schema * WIP: Test creation * WIP: Test creation * Finish updating specs * Clean up schema.rb * Update db/functions/gather_bfcorkeys_of_hearing_schedulable_legacy_cases_v01.sql * Lint fix * Testing that I am able to commit * Update spec/db/functions/gather_bfcorkeys_of_hearing_schedulable_legacy_cases_spec.rb * Switch to using quote_literal --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-57706
Description
A tracking PR for APPEALS-57706.