Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-library: Fixing the html element's font-size so it will respect browser settings #1444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/css-library/dist/stylesheets/base/va.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/css-library/dist/stylesheets/base/va.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/css-library/dist/stylesheets/core.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/css-library/dist/stylesheets/core.css.map

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions packages/css-library/src/stylesheets/base/va.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ body {
}

html {
font-size: $em-base;
font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings
font-weight: 500;
}

Expand Down Expand Up @@ -422,7 +422,7 @@ article > h1 {
padding-left: scale-rem(1rem);
}

// used mostly in content-build, we should consider moving this over there
// used mostly in content-build, we should consider moving this over there
.last-updated {
margin-top: 1.5em;
border-top: 2px solid $color-gray-light;
Expand All @@ -433,8 +433,8 @@ article > h1 {
}

// Feature style used on hub pages (example on /pension/how-to-apply), copied here from formation
// ToDo - These should be replaced with web-components:
// https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2338#top
// ToDo - These should be replaced with web-components:
// https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2338#top
// https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/2341#top

.feature {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

html {
font-family: tok.$font-family-sans;
font-size: vars.$em-base;
font-size: 100%; // Needs to be 100% to be able to grow and shrink with browser settings
}

body {
Expand Down
Loading