Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/10330-emptyPageAfterMovingMessage #10383

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

alexandec
Copy link
Contributor

Description of Change

If a user is on page 2 or greater in a Secure Messaging folder, the page has only one message, and they move that message to a different folder, go back to the previous page. This avoids showing them an empty message list.

The change applies to the inbox as well as all other folders.

Screenshots/Video

Before:

move-message-before.mp4

After:

move-message-after.mp4

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

User is brought back into the folder, on the 'prior' page (screen showing the 1-10 messages if you just deleted the 11th, the 11-20 messages if you just deleted the 21st, etc)

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@dumathane
Copy link
Contributor

I'm a little concerned about what happens when you have a folder with only one message and move it? Did you try that test case Chris?

@alexandec
Copy link
Contributor Author

@dumathane the conditional here checks that the current page is > 1 before setting the page to page - 1. So the code won't run if there's only one page of items. I can still test that on staging to be sure though

@alexandec
Copy link
Contributor Author

@dumathane works fine, you just get the "You don't have any messages in this folder" message. Video:

one.message.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants