Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/6261 chanel qa approval before pr merge workflow #8575

Closed

Conversation

IsraelleHub
Copy link
Contributor

Description of Change

This should be a Github actions workflow that:

Runs on each PR Open
Runs on each PR "approval"
Only runs when merges are going into develop
Only runs on code that requires both FE and QA review
Also:

It should run immediately with a failure, blocking merged for code QA needs to review
On each approval, it should rerun to test that there are at least 3 approvals, one of which is from a member of the QA team (flagship-mobile-qa). Ideally, if we can check team membership that would be best, but if not having users listed directly is fine.
the CODEOWNERS file outlines areas where the code needs QA approval for merge
Include code that touches the app:

VAMobile/src
VAMobile/e2e
VAMobile/package.json
VAMobile/.detoxrc.json

Exclude PRs with only unit tests:
VAMobile/src/*.test.tsx

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants