Automation/6261 chanel qa approval before pr merge workflow #8575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This should be a Github actions workflow that:
Runs on each PR Open
Runs on each PR "approval"
Only runs when merges are going into develop
Only runs on code that requires both FE and QA review
Also:
It should run immediately with a failure, blocking merged for code QA needs to review
On each approval, it should rerun to test that there are at least 3 approvals, one of which is from a member of the QA team (flagship-mobile-qa). Ideally, if we can check team membership that would be best, but if not having users listed directly is fine.
the CODEOWNERS file outlines areas where the code needs QA approval for merge
Include code that touches the app:
VAMobile/src
VAMobile/e2e
VAMobile/package.json
VAMobile/.detoxrc.json
Exclude PRs with only unit tests:
VAMobile/src/*.test.tsx
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch