clean up uses of require_dependency

[erluti]

Issue Description

require_dependency is no longer meaningful when zeitwerk loading is enabled. It should be removed throughout the app.

[erluti]

This PR is part of the work, department-of-veterans-affairs/vets-api#5787

Probably makes sense to do a PR for each module in the modules directory.

[holdenhinkle]

This is somewhat related - https://app.zenhub.com/workspaces/platform-cop-backlog-6359535e384ff5a473132130/issues/gh/department-of-veterans-affairs/va.gov-team/14689

[gia-lexa]

Out sick but am addressing this on my return.

[gia-lexa]

From the docs: https://guides.rubyonrails.org/classic_to_zeitwerk_howto.html#new-features-you-can-leverage

All known use cases of require_dependency have been eliminated with Zeitwerk. You should grep the project and delete them.

grep -r --exclude="*.html" "require_dependency" . | wc -l
107

Deleting instances and confirming those deletions don't break anything by running the test suite.

[gia-lexa]

This work is completed; expecting approval on remaining PRs today.

[gia-lexa]

Work is completed and merged; search of codebase shows no remaining instances of 'require_dependency'.

[pjhill]

Wow -- awesome! That's a ton of merged PRs!
It's gone --

[pjhill]

Oh @gia-lexa, I guess we are kind of cheating by assigning story points after the fact, but what would you estimate the points at for this task?

My estimate would be something like 5 points.

[gia-lexa]

That sounds reasonable, I went ahead updated the Estimate section of this ticket with "5".