Removes 'require_dependency' From 'spec/' #12594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vsp-bot
requested a deployment
to
gia_14688_require_dependency_spec_directory/main/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous upgrade to Rails 6.x brought the addition of Zeitwerk, Rails' code loader, which renders require_dependency statements unnecessary. As a result, we can remove these statements from our code.
This PR removes require_dependency specifically from the spec/models/webhook directory. Other PRs have been opened to address this issue in our modules.
This is part of an effort by Backend COP to remove some older code conventions that are no longer necessary as a result of Zeitwerk.
Issue(s)
Current Issue: Clean Up Use of 'require_dependency': department-of-veterans-affairs/va.gov-team#14688
Previous Related Work: Remove 'require_dependency' from App: #5787
Testing done
Redundant require_dependency statements removed and amended files pushed up.
Acceptance criteria
[ X ] No error nor warning as a result of running the test suite.