VRE | Investigate Schema Issues

[mjknight50]

Overview

There is an ongoing issue with schema validation, especially for VR&E. This ticket is to track the work associated with the issue.

This issue spans multiple forms.

Related Issue

#83680

[mjknight50]

Update on this issue. The gem file being used by the vets-api is called json-schema

Within vets-api, we use two specific functions in app/models/saved_claim.rb

There is no documentation for the functions:
https://github.com/voxpupuli/json-schema/blob/edb815ad358cd130ebca3216b35f1b7490e958cd/lib/json-schema/validator.rb#L275
https://github.com/voxpupuli/json-schema/blob/edb815ad358cd130ebca3216b35f1b7490e958cd/lib/json-schema/validator.rb#L279

It seems like fully_validate takes a given JSON payload and validates it against a schema.
Whereas fully_validate_schema just validates that the schema is valid.

We've using JSON::Validator.fully_validate_schema(schema, { errors_as_objects: true }) which works from what we can tell. Within the gem, that function calls fully_validate

Then, we've got JSON::Validator.fully_validate(schema, parsed_form, { errors_as_objects: true, clear_cache: })
Which is the same thing being called by fully_validate_schema but that one errors out.

On top of that all, the gem is no longer maintained. It seems like this one might have more support:
https://github.com/davishmcclurg/json_schemer

[mjknight50]

@coope93 is proposing that we hide the fully_validate_schema behind a flipper for now.
department-of-veterans-affairs/vets-api#19468

[mjknight50]

I've posted most of my findings to https://dsva.slack.com/archives/C053U7BUT27/p1732119843278369
An engineer from @shaunburdick or @dysbo team may pick this up.