[10-10CG] Add ability to not call fully_validate_schema in SavedClaim #19468

coope93 · 2024-11-14T21:29:54Z

Summary

This work is behind a feature toggle (flipper): YES
Added a flipper toggle to allow us to turn off recently added functionality to call the fully_validate_schema in the json-schema gem. This call was added to try to validate the schema without the form content to handle some errors that were being seen, but seems to have potentially introduced another error that's causing the schema file to not be read in the subsequent fully_validate call. This is the only location where we are currently calling fully_validate_schema (we call fully_validate other places), and it is the only one experiencing the issue. This PR adds a flipper toggle that allows us to skip that validation step.
10-10 Health Apps
Flipper toggle saved_claim_schema_validation_disable

Related issue(s)

Testing done

New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

Any model that inherits from the SavedClaim

Acceptance criteria

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No error nor warning in the console.
Events are being sent to the appropriate logging solution
Documentation has been updated (link to documentation)
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Feature/bug has a monitor built into Datadog (if applicable)
If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

mjknight50

GTG
For context for anyone else taking a look at this --> Brandon and I have been discussing an issue with schema-validation for several days. This PR is an attempt to isolate the difference in behavior between fully_validate_schema and fully_validate

… saved_claim

…l be default

coope93 · 2024-11-15T16:23:39Z

spec/lib/bgs/form674_spec.rb

  context 'The flipper is turned on' do
    before do
-      Flipper.enable(:dependents_enqueue_with_user_struct)
+      allow(Flipper).to receive(:enabled?).with(:dependents_enqueue_with_user_struct).and_return(true)


Change these to stubs instead of actually enabling/disabling the toggle. Added stub at the top to default to original values to handle any that are not stubbed.

coope93 · 2024-11-15T16:25:16Z

spec/requests/swagger_spec.rb

@@ -3270,6 +3270,10 @@
    end

    describe 'contact us' do
+      before do


These were failing because some expectations were validating that some toggle was set and the new Flipper call in saved_claim was expecting it. I added this to default all to call the original so any that don't have explicit expectations won't fail.

github-actions · 2024-11-15T19:29:53Z

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/controllers/v0/contact_us/inquiries_controller_spec.rb

github-actions · 2024-11-15T19:48:39Z

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/controllers/v0/contact_us/inquiries_controller_spec.rb

coope93 · 2024-11-15T20:08:38Z

.github/CODEOWNERS

@@ -1107,6 +1107,7 @@ spec/controllers/v0/benefits_reference_data_controller_spec.rb @department-of-ve
 spec/controllers/v0/burial_claims_controller_spec.rb @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb @department-of-veterans-affairs/vfs-10-10
 spec/controllers/v0/claim_letters_controller_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/controllers/v0/contact_us @department-of-veterans-affairs/ask-va-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group


Apparently this was missing? The github job flagged it since I had updated one of the specs in the directory so I went ahead and added the codeowners to match the actual implementation directory.

mjknight50

GTG

github-actions · 2024-11-18T17:11:03Z

Backend-review-group approval confirmed.

coope93 added 2 commits November 14, 2024 15:24

add new flipper toggle

3a6d104

add logic to skip fully_validate_schema when toggle is turned on

852ca8f

github-actions bot added the test-failure label Nov 14, 2024

va-vfs-bot temporarily deployed to 95897-disable-fully-validate-schema/main/main November 14, 2024 21:39 Inactive

mjknight50 marked this pull request as ready for review November 15, 2024 13:20

mjknight50 requested review from a team as code owners November 15, 2024 13:20

mjknight50 previously approved these changes Nov 15, 2024

View reviewed changes

github-actions bot added require-backend-approval and removed require-backend-approval labels Nov 15, 2024

mjknight50 mentioned this pull request Nov 15, 2024

VRE | Investigate Schema Issues department-of-veterans-affairs/va.gov-team#95099

Closed

add flipper toggle expect to spec since it is calling the valid? on a…

278c97d

… saved_claim

coope93 dismissed mjknight50’s stale review via 278c97d November 15, 2024 15:39

coope93 requested a review from a team as a code owner November 15, 2024 15:39

github-actions bot added require-backend-approval and removed require-backend-approval labels Nov 15, 2024

update specs to handle extra flipper call in stubs by calling origina…

e2842e0

…l be default

github-actions bot added require-backend-approval and removed require-backend-approval labels Nov 15, 2024

coope93 commented Nov 15, 2024

View reviewed changes

va-vfs-bot temporarily deployed to 95897-disable-fully-validate-schema/main/main November 15, 2024 16:46 Inactive

coope93 marked this pull request as draft November 15, 2024 17:08

stub flipper enabled call to call original for some specs

7bf174d

github-actions bot removed the require-backend-approval label Nov 15, 2024

github-actions bot added codeowners-addition-failure test-passing and removed test-failure labels Nov 15, 2024

Merge branch 'master' into 95897-disable-fully-validate-schema

632c00d

github-actions bot added test-passing and removed test-passing labels Nov 15, 2024

add codeowner for spec file

a9f505d

github-actions bot added test-passing and removed codeowners-addition-failure test-passing labels Nov 15, 2024

coope93 commented Nov 15, 2024

View reviewed changes

mjknight50 approved these changes Nov 15, 2024

View reviewed changes

coope93 marked this pull request as ready for review November 15, 2024 20:50

coope93 requested a review from a team as a code owner November 15, 2024 20:50

github-actions bot added require-backend-approval and removed require-backend-approval labels Nov 15, 2024

va-vfs-bot deployed to 95897-disable-fully-validate-schema/main/main November 15, 2024 22:41 View deployment

rmtolmach approved these changes Nov 18, 2024

View reviewed changes

mjknight50 mentioned this pull request Nov 18, 2024

Update the json-schema gem version department-of-veterans-affairs/va.gov-team#93504

Closed

1 task

coope93 merged commit 729b8ac into master Nov 18, 2024
52 of 53 checks passed

coope93 deleted the 95897-disable-fully-validate-schema branch November 18, 2024 17:32

rmtolmach mentioned this pull request Nov 18, 2024

Revert "[10-10CG] Add ability to not call fully_validate_schema in SavedClaim" #19493

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10-10CG] Add ability to not call fully_validate_schema in SavedClaim #19468

[10-10CG] Add ability to not call fully_validate_schema in SavedClaim #19468

coope93 commented Nov 14, 2024 •

edited

Loading

mjknight50 left a comment •

edited

Loading

coope93 Nov 15, 2024

coope93 Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

coope93 Nov 15, 2024 •

edited

Loading

rmtolmach Nov 18, 2024

mjknight50 left a comment

github-actions bot commented Nov 18, 2024

[10-10CG] Add ability to not call fully_validate_schema in SavedClaim #19468

[10-10CG] Add ability to not call fully_validate_schema in SavedClaim #19468

Conversation

coope93 commented Nov 14, 2024 • edited Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Requested Feedback

mjknight50 left a comment • edited Loading

Choose a reason for hiding this comment

coope93 Nov 15, 2024

Choose a reason for hiding this comment

coope93 Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

coope93 Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

rmtolmach Nov 18, 2024

Choose a reason for hiding this comment

mjknight50 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024

coope93 commented Nov 14, 2024 •

edited

Loading

mjknight50 left a comment •

edited

Loading

coope93 Nov 15, 2024 •

edited

Loading