Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch database connection error for polling jobs #95986

Closed
21 tasks
comaurice opened this issue Oct 28, 2024 · 1 comment
Closed
21 tasks

Catch database connection error for polling jobs #95986

comaurice opened this issue Oct 28, 2024 · 1 comment
Assignees
Labels
Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined

Comments

@comaurice
Copy link
Contributor

comaurice commented Oct 28, 2024

Value Statement

As a Dev

I want to be aware of any database connection error for polling jobs

So that we can prevent an uncaught polling error


Background Context

  • In Cron jobs, first call checks for matching criteria for records. NO rescue on first query, the job throws an error into WatchTower queue.

[Line where error happens] (https://github.com/department-of-veterans-affairs/vets-api/blob/master/app/sidekiq/decision_review/saved_claim_hlr_status_updater_job.rb#L22)

Outcome, Success Measure, KPI(S), and Tracking Link

  • Add here

Acceptance Criteria

  • Code update confirms notification of any caught errors
  • AC
  • AC

Designs and Build Notes

  • Add here

Enablement team (if needed)

@ member of team

Out of scope

  • Add here

Open questions

  • Add here

Tasks

  • Task
  • Task
  • Task

Definition of Ready

  • Clear value description
  • Testable acceptance criteria
  • Accessibility added to acceptance criteria
  • Approved designs attached
  • Sample data provided where appropriate
  • Estimated to fit within the sprint
  • Dependencies and blockers linked

Definition of Done

  • Meets acceptance criteria
  • Passed E2E testing (90% coverage)
  • Passed unit testing (90% coverage)
  • Passed integration testing (if applicable)
  • Code reviewed (internal)
  • Submitted to staging
  • Team approved production verification process
  • Reviewed and approved by product and/or design
@comaurice comaurice added Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined labels Oct 28, 2024
@eileen-coforma
Copy link
Contributor

Dependent on #96645 to merge before this can clos.

@kayline kayline closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined
Projects
None yet
Development

No branches or pull requests

3 participants