Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor status update jobs #96645

Closed
15 tasks
kayline opened this issue Nov 7, 2024 · 2 comments
Closed
15 tasks

Refactor status update jobs #96645

kayline opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined tech-debt

Comments

@kayline
Copy link
Contributor

kayline commented Nov 7, 2024

Value Statement

As a engineer

I want to to reduce code duplication

So that it's easier to maintain and understand the codebase


Background Context

  • We need to check on the status of 3 different forms, and possibly associated evidence and secondary forms. Right now each job has very similar code, and it feels a bit messy. Can we create a base job with the shared code? Will that help reveal some ways to simplify the logic?

Outcome, Success Measure, KPI(S), and Tracking Link

  • Fewer lines of code, same functionality, still readable

Out of scope

  • The notification jobs, or original form tracking

Open questions

  • Add here

Definition of Ready

  • Clear value description
  • Testable acceptance criteria
  • Accessibility added to acceptance criteria
  • Approved designs attached
  • Sample data provided where appropriate
  • Estimated to fit within the sprint
  • Dependencies and blockers linked

Definition of Done

  • Meets acceptance criteria
  • Passed E2E testing (90% coverage)
  • Passed unit testing (90% coverage)
  • Passed integration testing (if applicable)
  • Code reviewed (internal)
  • Submitted to staging
  • Team approved production verification process
  • Reviewed and approved by product and/or design
@kayline kayline added Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined tech-debt labels Nov 7, 2024
@dfong-adh
Copy link
Contributor

In progress, will have a PR ready soon.

@eileen-coforma
Copy link
Contributor

Platform review wait period. Waiting for 2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Decision-Reviews-Team (Formerly squad-2) Label for issues being worked on by Decision Reviews on BMT & DR team needs-refinement Identifies tickets that need to be refined tech-debt
Projects
None yet
Development

No branches or pull requests

3 participants