Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract shared examples for status update jobs #19562

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

kayline
Copy link
Contributor

@kayline kayline commented Nov 21, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • Refactor only: Extract shared examples for status update jobs but do not use them yet
  • Trying to minimize dependent PRs while staying under the limit for lines of code changed
  • Decision Reviews, yes

Related issue(s)

department-of-veterans-affairs/va.gov-team#96645

Testing done

  • New code is covered by unit tests
    -The same setup and behavior tests were duplicated for each of the three subclasses that implements the base job. Now there is a single shared examples file. Future PRs will update the job specs to use these shared examples.

What areas of the site does it impact?

Add shared examples but do not use yet

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

- base form tests only
- use in HLR job only to keep PR small
Copy link

github-actions bot commented Nov 21, 2024

1 Warning
⚠️ This PR changes 317 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • spec/sidekiq/decision_review/shared_examples_for_status_updater_jobs.rb (+317/-0)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

- not using them in any spec files yet
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kayline kayline marked this pull request as ready for review November 21, 2024 21:45
@kayline kayline requested review from a team as code owners November 21, 2024 21:45
@kayline kayline merged commit 3113d5c into master Nov 21, 2024
50 checks passed
@kayline kayline deleted the DR-refactor-hlr-status-check-spec branch November 21, 2024 22:04
SnowboardTechie pushed a commit that referenced this pull request Nov 25, 2024
* Extract shared examples for status update jobs
- not using them in any spec files yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants