Dr refactor nod status update specs

[kayline]

Summary

• This work is behind a feature toggle (flipper): YES/NO
• Refactor only: Use shared examples in NOD job spec
• Decision Reviews, yes

Related issue(s)

department-of-veterans-affairs/va.gov-team#96645

Testing done

• New code is covered by unit tests
  -The same setup and behavior tests were duplicated for each of the three subclasses that implements the base job. This applies the shared examples to one (NOD) of three spec files
• Break the job, ensure tests fail as expected

What areas of the site does it impact?

Refactor tests for the nod_status_update_job.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 291 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files spec/sidekiq/decision_review/nod_status_updater_job_spec.rb (+4/-287) spec/sidekiq/decision_review/shared_examples_for_status_updater_jobs.rb (+0/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[shaunburdick]

LGTM