Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SupplementalClaim status update spec #19567

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

kayline
Copy link
Contributor

@kayline kayline commented Nov 21, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • Refactor only: Use shared examples in SC job spec
  • Decision Reviews, yes

Related issue(s)

department-of-veterans-affairs/va.gov-team#96645

Testing done

  • New code is covered by unit tests
    -The same setup and behavior tests were duplicated for each of the three subclasses that implements the base job. This applies the shared examples to one (SC) of three spec files
  • Break the job, ensure tests fail as expected

What areas of the site does it impact?

Refactor tests for the sc_status_update_job.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link

github-actions bot commented Nov 21, 2024

1 Warning
⚠️ This PR changes 433 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • spec/sidekiq/decision_review/sc_status_updater_job_spec.rb (+6/-427)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@kayline kayline force-pushed the DR-refactor-sc-status-update-spec branch from e140908 to 693ba25 Compare November 21, 2024 22:15
@kayline kayline force-pushed the DR-refactor-sc-status-update-spec branch from 693ba25 to 22f42ea Compare November 21, 2024 22:19
@kayline kayline marked this pull request as ready for review November 21, 2024 22:29
@kayline kayline requested review from a team as code owners November 21, 2024 22:29
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Backend-review-group approval confirmed.

@kayline kayline merged commit b08d630 into master Nov 22, 2024
34 of 36 checks passed
@kayline kayline deleted the DR-refactor-sc-status-update-spec branch November 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants