Refactor status check job for decision review forms

[kayline]

Summary

• This work is behind a feature toggle (flipper): NO
• No behavior changes, just extracting shared code to a base job

Related issue(s)

department-of-veterans-affairs/va.gov-team#96645

Testing done

• New code is covered by unit tests
• Each appeal form had it's own job with most of the code duplicated. There is now a base job for checking the status of appeals forms (and evidence). Each specific form type has a job that inherits from the base job
• Ensure that status update timestamps continue to increment each time the jobs are run.

What areas of the site does it impact?

No user-facing impact. Refactor of existing code to check status in Lighthouse

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 415 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/sidekiq/decision_review/hlr_status_updater_job.rb (+30/-0) app/sidekiq/decision_review/nod_status_updater_job.rb (+33/-0) app/sidekiq/decision_review/saved_claim_hlr_status_updater_job.rb (+0/-59) app/sidekiq/decision_review/saved_claim_nod_status_updater_job.rb (+0/-94) app/sidekiq/decision_review/{saved_claim_sc_status_updater_job.rb => saved_claim_status_updater_job.rb} (+81/-50) app/sidekiq/decision_review/sc_status_updater_job.rb (+36/-0) lib/periodic_jobs.rb (+3/-3) spec/sidekiq/decision_review/{saved_claim_hlr_status_updater_job_spec.rb => hlr_status_updater_job_spec.rb} (+5/-1) spec/sidekiq/decision_review/{saved_claim_nod_status_updater_job_spec.rb => nod_status_updater_job_spec.rb} (+9/-1) spec/sidekiq/decision_review/{saved_claim_sc_status_updater_job_spec.rb => sc_status_updater_job_spec.rb} (+9/-1) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[kayline]

1 Warning
⚠️ This PR changes 433 LoC (not counting whitespace/newlines).
In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews.

File Summary
Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Very little new code, just file re-naming and deletion of duplicate code

[dfong-adh]

LGTM, just need to update this file to use the new job names. Also I'm assuming we don't need saved_claim_sc_status_updater_job.rb anymore either?

[github-actions]

Backend-review-group approval confirmed.