-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate specs for status update jobs #19463
Conversation
Generated by 🚫 Danger |
e4f9659
to
5faec8e
Compare
5b8da4a
to
d599afd
Compare
d599afd
to
0880f9b
Compare
- add rescus to base class - add tests to each subclass
- needs fix to decision review service to make method signatures match
- was :uuid, now :guid - to match get_notice_of_disagreement_upload for easier code sharing and shared testing
0880f9b
to
418e840
Compare
-fix conflicts in status updater job specs
Closing in favor of four smaller PRs |
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#96645
Testing done
-The same setup and behavior tests were duplicated for each of the three subclasses that implements the base job. Now there is a single shared examples file that each spec references
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria