Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Silent Failures for PCI & OH Travel #98378

Closed
loripusey opened this issue Dec 4, 2024 · 1 comment
Closed

Log Silent Failures for PCI & OH Travel #98378

loripusey opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels

Comments

@loripusey
Copy link
Contributor

loripusey commented Dec 4, 2024

Slack thread

We need to start reporting when a Silent Failure happen to the data dog dashboard. Since we have a Silent Failure in the Travel Pay flow, we need to start reporting when that happens.

It looks like a low lift; Here are the direction from the team . Looks like we need to increment a statsd metric when we think it happens.

We should add something like this when we detect that the claim was failed and the text message failed to send
tags = ['service:veteran-facing-forms', 'function: Day of CheckIn Travel pay Travel Pay Notification Failure']
StatsD.increment('silent_failure', tags:)

I would say this is a work on next sprint priority.

Tasks

  • Log the silent failure to DD
  • Update the RSpecs
  • Determine if the logged failure has occurred
  • Create a F/U ticket to leave as a reminder in the current sprint to check this until we see that it has worked and then create a dashboard for it
@kanchanasuriya
Copy link
Contributor

Identified a way to add the silent_failure metrics in travel claims dashboard & updated the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants