Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

98378 Logging travel claim silent failure metric in CIE #19908

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

kanchanasuriya
Copy link
Contributor

Summary

  • Logging silent failure metric in CIE travel pay workflow

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
NA

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

\

@va-vfs-bot va-vfs-bot temporarily deployed to 98378_Travel_claims_log_silent_failure/main/main December 16, 2024 17:21 Inactive
Copy link
Member

@randomsync randomsync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kanchanasuriya kanchanasuriya merged commit 5df0b67 into master Dec 17, 2024
29 of 30 checks passed
@kanchanasuriya kanchanasuriya deleted the 98378_Travel_claims_log_silent_failure branch December 17, 2024 20:43
derekhouck pushed a commit that referenced this pull request Dec 31, 2024
…& OH Travel Pay (#19908)

Co-authored-by: kanchanasuriya <ksuriyamoorthy@kindsys.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants