Skip to content

Commit

Permalink
WIP shared examples for status update jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
@kayline
kayline committed Nov 18, 2024
1 parent d356683 commit 3134638
Show file tree
Hide file tree
Showing 4 changed files with 193 additions and 557 deletions.
137 changes: 3 additions & 134 deletions spec/sidekiq/decision_review/hlr_status_updater_job_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,151 +2,20 @@

require 'rails_helper'
require 'decision_review_v1/service'
require 'sidekiq/decision_review/shared_examples_for_status_updater_jobs'

RSpec.describe DecisionReview::HlrStatusUpdaterJob, type: :job do
subject { described_class }

let(:service) { instance_double(DecisionReviewV1::Service) }

let(:guid1) { SecureRandom.uuid }
let(:guid2) { SecureRandom.uuid }
let(:guid3) { SecureRandom.uuid }

let(:response_complete) do
response = JSON.parse(VetsJsonSchema::EXAMPLES.fetch('HLR-SHOW-RESPONSE-200_V2').to_json) # deep copy
response['data']['attributes']['status'] = 'complete'
instance_double(Faraday::Response, body: response)
end

let(:response_pending) do
instance_double(Faraday::Response, body: VetsJsonSchema::EXAMPLES.fetch('HLR-SHOW-RESPONSE-200_V2'))
end

let(:response_error) do
response = JSON.parse(VetsJsonSchema::EXAMPLES.fetch('SC-SHOW-RESPONSE-200_V2').to_json) # deep copy
response['data']['attributes']['status'] = 'error'
instance_double(Faraday::Response, body: response)
end

before do
allow(DecisionReviewV1::Service).to receive(:new).and_return(service)
end
include_context 'status updater job context', SavedClaim::HigherLevelReview

describe 'perform' do
context 'with flag enabled', :aggregate_failures do
before do
Flipper.enable :decision_review_saved_claim_hlr_status_updater_job_enabled
allow(StatsD).to receive(:increment)
end

context 'SavedClaim records are present' do
before do
SavedClaim::HigherLevelReview.create(guid: guid1, form: '{}')
SavedClaim::HigherLevelReview.create(guid: guid2, form: '{}')
SavedClaim::HigherLevelReview.create(guid: guid3, form: '{}', delete_date: DateTime.new(2024, 2, 1).utc)
SavedClaim::SupplementalClaim.create(form: '{}')
SavedClaim::NoticeOfDisagreement.create(form: '{}')
end

it 'updates SavedClaim::HigherLevelReview delete_date for completed records without a delete_date' do
expect(service).to receive(:get_higher_level_review).with(guid1).and_return(response_complete)
expect(service).to receive(:get_higher_level_review).with(guid2).and_return(response_pending)
expect(service).not_to receive(:get_higher_level_review).with(guid3)

expect(service).not_to receive(:get_notice_of_disagreement)
expect(service).not_to receive(:get_supplemental_claim)

frozen_time = DateTime.new(2024, 1, 1).utc

Timecop.freeze(frozen_time) do
subject.new.perform

claim1 = SavedClaim::HigherLevelReview.find_by(guid: guid1)
expect(claim1.delete_date).to eq frozen_time + 59.days
expect(claim1.metadata).to include 'complete'
expect(claim1.metadata_updated_at).to eq frozen_time

claim2 = SavedClaim::HigherLevelReview.find_by(guid: guid2)
expect(claim2.delete_date).to be_nil
expect(claim2.metadata).to include 'pending'
expect(claim2.metadata_updated_at).to eq frozen_time

expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.processing_records', 2).exactly(1).time
expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.delete_date_update').exactly(1).time
expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.status', tags: ['status:pending'])
.exactly(1).time
end
end

it 'handles request errors and increments the statsd metric' do
allow(service).to receive(:get_higher_level_review).and_raise(DecisionReviewV1::ServiceException)

subject.new.perform

expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.error').exactly(2).times
end
end

context 'SavedClaim record with previous metadata' do
before do
allow(Rails.logger).to receive(:info)
end

it 'does not increment metrics for unchanged form status' do
SavedClaim::HigherLevelReview.create(guid: guid1, form: '{}', metadata: '{"status":"error"}')
SavedClaim::HigherLevelReview.create(guid: guid2, form: '{}', metadata: '{"status":"submitted"}')
SavedClaim::HigherLevelReview.create(guid: guid3, form: '{}', metadata: '{"status":"pending"}')

expect(service).to receive(:get_higher_level_review).with(guid1).and_return(response_error)
expect(service).to receive(:get_higher_level_review).with(guid2).and_return(response_error)
expect(service).to receive(:get_higher_level_review).with(guid3).and_return(response_pending)

subject.new.perform

claim1 = SavedClaim::HigherLevelReview.find_by(guid: guid1)
expect(claim1.delete_date).to be_nil
expect(claim1.metadata).to include 'error'

claim2 = SavedClaim::HigherLevelReview.find_by(guid: guid2)
expect(claim2.delete_date).to be_nil
expect(claim2.metadata).to include 'error'

expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.status', tags: ['status:error'])
.exactly(1).time
expect(StatsD).not_to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.status', tags: ['status:pending'])

expect(Rails.logger).not_to have_received(:info)
.with('DecisionReview::SavedClaimHlrStatusUpdaterJob form status error', guid: guid1)
expect(Rails.logger).to have_received(:info)
.with('DecisionReview::SavedClaimHlrStatusUpdaterJob form status error', guid: guid2)
expect(StatsD).to have_received(:increment)
.with('silent_failure', tags: ['service:higher-level-review',
'function: form submission to Lighthouse'])
.exactly(1).time
end
end

context 'Retrieving SavedClaim records fails' do
before do
allow(SavedClaim::HigherLevelReview).to receive(:where).and_raise(ActiveRecord::ConnectionTimeoutError)
allow(Rails.logger).to receive(:error)
end

it 'rescues the error and logs' do
subject.new.perform

expect(Rails.logger).to have_received(:error)
.with('DecisionReview::SavedClaimHlrStatusUpdaterJob error', anything)
expect(StatsD).to have_received(:increment)
.with('worker.decision_review.saved_claim_hlr_status_updater.error').once
end
end
include_examples 'status updater job with base forms', SavedClaim::HigherLevelReview
end

context 'with flag disabled' do
Expand Down
Loading

0 comments on commit 3134638

Please sign in to comment.