Merge branch 'master' into ip/1429-v2

.github/CODEOWNERS

@@ -1502,6 +1502,7 @@ spec/lib/pdf_info/metadata_spec.rb @department-of-veterans-affairs/va-api-engine
 spec/lib/pdf_utilities @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/pension_burial @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/pension21p527ez/pension_military_information_spec.rb @department-of-veterans-affairs/pension-and-burials @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/lib/periodic_jobs_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/backend-review-group
 spec/lib/preneeds @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/post911_sob @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/rx @department-of-veterans-affairs/vfs-mhv-medications

Gemfile

@@ -207,6 +207,7 @@ group :development, :test do
   gem 'byebug', platforms: :ruby # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   gem 'danger'
   gem 'database_cleaner'
+  gem 'debug'
   gem 'factory_bot_rails'
   gem 'faker'
   # CAUTION: faraday_curl may not provide all headers used in the actual faraday request. Be cautious if using this to

Gemfile.lock

@@ -313,7 +313,7 @@ GEM
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
     colored2 (3.1.2)
-    combine_pdf (1.0.26)
+    combine_pdf (1.0.29)
       matrix
       ruby-rc4 (>= 0.1.5)
     committee (5.4.0)
@@ -375,6 +375,9 @@ GEM
       libddwaf (~> 1.14.0.0.0)
       msgpack
     debase-ruby_core_source (3.3.1)
+    debug (1.9.2)
+      irb (~> 1.10)
+      reline (>= 0.3.8)
     declarative (0.0.20)
     deep_merge (1.2.2)
     descendants_tracker (0.0.4)
@@ -1181,6 +1184,7 @@ DEPENDENCIES
   date_validator
   ddtrace
   debts_api!
+  debug
   decision_reviews!
   dhp_connected_devices!
   dogstatsd-ruby (= 5.6.3)

app/controllers/v0/disability_compensation_forms_controller.rb

@@ -35,9 +35,10 @@ def separation_locations
         :all_users,
         :get_separation_locations
       ) do
+        provider = Flipper.enabled?(:disability_compensation_staging_lighthouse_brd) ? :lighthouse_staging : nil
         api_provider = ApiProviderFactory.call(
           type: ApiProviderFactory::FACTORIES[:brd],
-          provider: nil,
+          provider:,
           options: {},
           current_user: @current_user,
           feature_toggle: ApiProviderFactory::FEATURE_TOGGLE_BRD

config/features.yml

@@ -87,6 +87,9 @@ features:
   caregiver_retry_form_validation:
     actor_type: user
     description: Enables 1010CG to retry schema validation
+  disability_compensation_staging_lighthouse_brd:
+    actor_type: user
+    description: Switches to Lighthouse Staging BRD Service. NEVER ENABLE IN PRODUCTION.
   hca_browser_monitoring_enabled:
     actor_type: user
     description: Enables browser monitoring for the health care application.

db/migrate/20241213171608_add_path_to_banners.rb

@@ -0,0 +1,5 @@
+class AddPathToBanners < ActiveRecord::Migration[7.2]
+  def change
+    add_column :banners, :path, :string
+  end
+end

db/migrate/20241213173113_add_index_to_banners_path.rb

@@ -0,0 +1,7 @@
+class AddIndexToBannersPath < ActiveRecord::Migration[7.2]
+  disable_ddl_transaction!
+
+  def change
+    add_index :banners, :path, algorithm: :concurrently
+  end
+end

lib/disability_compensation/factories/api_provider_factory.rb

@@ -15,6 +15,7 @@
 require 'disability_compensation/providers/brd/brd_provider'
 require 'disability_compensation/providers/brd/evss_brd_provider'
 require 'disability_compensation/providers/brd/lighthouse_brd_provider'
+require 'disability_compensation/providers/brd/lighthouse_staging_brd_provider'
 require 'disability_compensation/providers/generate_pdf/generate_pdf_provider'
 require 'disability_compensation/providers/generate_pdf/evss_generate_pdf_provider'
 require 'disability_compensation/providers/generate_pdf/lighthouse_generate_pdf_provider'
@@ -28,7 +29,8 @@ class UndefinedFactoryTypeError < StandardError; end
 
   API_PROVIDER = {
     evss: :evss,
-    lighthouse: :lighthouse
+    lighthouse: :lighthouse,
+    lighthouse_staging: :lighthouse_staging
   }.freeze
 
   FACTORIES = {
@@ -166,6 +168,8 @@ def brd_service_provider
       EvssBRDProvider.new(@current_user)
     when API_PROVIDER[:lighthouse]
       LighthouseBRDProvider.new(@current_user)
+    when API_PROVIDER[:lighthouse_staging]
+      LighthouseStagingBRDProvider.new(@current_user)
     else
       raise NotImplementedError, 'No known BRD Api Provider type provided'
     end

lib/disability_compensation/providers/brd/lighthouse_staging_brd_provider.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'disability_compensation/providers/brd/lighthouse_brd_provider'
+require 'lighthouse/benefits_reference_data_staging/service'
+
+class LighthouseStagingBRDProvider < LighthouseBRDProvider
+  def initialize(_current_user)
+    super
+    @service = BenefitsReferenceData::Staging::Service.new
+  end
+end

lib/lighthouse/benefits_reference_data_staging/configuration.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require 'common/client/configuration/rest'
+require 'faraday/multipart'
+
+module BenefitsReferenceData
+  ##
+  # HTTP client configuration for the {BenefitsReferenceData::Service},
+  # sets the base path, the base request headers, and a service name for breakers and metrics.
+
+  module Staging
+    class Configuration < Common::Client::Configuration::REST
+      self.read_timeout = Settings.lighthouse.benefits_reference_data.timeout || 20
+
+      ##
+      # @return [String] Base path for benefits_reference_data URLs.
+      #
+      def base_path
+        settings = Settings.lighthouse.benefits_reference_data
+        url = settings.staging_url
+        path = settings.path
+        version = settings.version
+        safe_slash_merge(url, path, version)
+      end
+
+      ##
+      # @return [String] Service name to use in breakers and metrics.
+      #
+      def service_name
+        'BenefitsReferenceDataStaging'
+      end
+
+      ##
+      # @return [Hash] The basic headers required for any benefits_reference_data API call.
+      #
+      def self.base_request_headers
+        key = Settings.lighthouse.staging_api_key
+        message = "No api_key set for LH benefits_reference_data_staging. Please set 'lighthouse.staging_api_key'"
+        raise message if key.nil?
+
+        super.merge('apiKey' => key)
+      end
+
+      ##
+      # Creates the a connection with parsing json and adding breakers functionality.
+      #
+      # @return [Faraday::Connection] a Faraday connection instance.
+      #
+      def connection
+        @conn ||= Faraday.new(base_path, headers: base_request_headers, request: request_options) do |faraday|
+          faraday.use      :breakers
+          faraday.use      Faraday::Response::RaiseError
+
+          faraday.request :multipart
+          faraday.request :json
+          faraday.response :json
+          faraday.adapter Faraday.default_adapter
+        end
+      end
+
+      private
+
+      def safe_slash_merge(*url_segments)
+        url_segments.map { |segment| segment.sub(%r{^/}, '').chomp('/') }.join('/')
+      end
+    end
+  end
+end

lib/lighthouse/benefits_reference_data_staging/service.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require 'common/client/base'
+require 'common/client/concerns/monitoring'
+require 'common/client/errors'
+require 'common/exceptions/forbidden'
+require 'common/exceptions/schema_validation_errors'
+require 'lighthouse/benefits_reference_data_staging/configuration'
+require 'lighthouse/benefits_reference_data/service_exception'
+
+module BenefitsReferenceData
+  ##
+  # Proxy Service for the Lighthouse Benefits Reference Data API.
+
+  module Staging
+    class Service < Common::Client::Base
+      include SentryLogging
+      include Common::Client::Concerns::Monitoring
+
+      configuration BenefitsReferenceData::Staging::Configuration
+
+      # ap @configuration.base_request_headers; exit
+
+      STATSD_KEY_PREFIX = 'api.benefits_reference_data_staging'
+
+      ##
+      # Hit a Benefits Reference Data End-point
+      #
+      # @path end-point [string|symbol] a string or symbol of the end-point you wish to hit.
+      # @params params hash [Hash] a hash of key-value pairs of parameters
+      #
+      # @return [Faraday::Response]
+      #
+      def get_data(path:, params: {})
+        headers = config.base_request_headers
+        begin
+          response = perform :get, path, params, headers
+        rescue => e
+          raise BenefitsReferenceData::ServiceException.new(e), 'Lighthouse Error'
+        end
+        response
+      end
+    end
+  end
+end

lib/periodic_jobs.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'holidays'
+
 # @see https://crontab.guru/
 # @see https://en.wikipedia.org/wiki/Cron
 PERIODIC_JOBS = lambda { |mgr| # rubocop:disable Metrics/BlockLength
@@ -249,10 +251,8 @@
   # Daily 0000 hrs job for Vye: performs ingress of state from BDN & TIMS.
   mgr.register('15 00 * * 1-5', 'Vye::MidnightRun::IngressBdn')
   mgr.register('45 03 * * 1-5', 'Vye::MidnightRun::IngressTims')
-
   # Daily 0600 hrs job for Vye: activates ingressed state, and egresses the changes for the day.
   mgr.register('45 05 * * 1-5', 'Vye::DawnDash')
-
-  # Daily job for Vye: clears deactivated BDNs every evening.
+  # Daily 1900 job for Vye: clears deactivated BDNs every evening.
   mgr.register('00 19 * * 1-5', 'Vye::SundownSweep')
 }

modules/claims_api/app/swagger/claims_api/description/v2.md

@@ -28,7 +28,7 @@ End-to-end claims tracking provides the status of claims as they move through th
 
 ### Claim statuses
 
-After you submit a disability compensation claim with the `POST /veterans/{veteranId}/526` synchronous endpoint, it is then established in Veterans Benefits Management System (VBMS). A `202` response means that the claim was successfully submitted by the API. However, it does not mean VA has received the required 526EZ PDF. 
+After you submit a disability compensation claim with the `POST /veterans/{veteranId}/526/synchronous` endpoint, it is then established in Veterans Benefits Management System (VBMS). A `202` response means that the claim was successfully submitted by the API. However, it does not mean VA has received the required 526EZ PDF. 
 
 To confirm the status of your submission, use the `GET /veterans/{veteranId}/claims/{id}` endpoint and the ID returned with your submission response. Statuses are: