use ordered arguments

department-of-veterans-affairs · Nov 15, 2024 · bc6ef6b · bc6ef6b
1 parent 97ccbdb
commit bc6ef6b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/...claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/request_controller.rb b/...claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/request_controller.rb
@@ -112,8 +112,7 @@ def send_declined_notification(ptcpnt_id:, first_name:, representative_id:)
           encrypted_ptcpnt_id = Base64.strict_encode64(lockbox.encrypt(ptcpnt_id))
           encrypted_first_name = Base64.strict_encode64(lockbox.encrypt(first_name))
 
-          ClaimsApi::VANotifyDeclinedJob.perform_async(encrypted_ptcpnt_id:, encrypted_first_name:,
-                                                       representative_id:)
+          ClaimsApi::VANotifyDeclinedJob.perform_async(encrypted_ptcpnt_id, encrypted_first_name, representative_id)
         end
 
         def validate_ptcpnt_id!(ptcpnt_id:, proc_id:, representative_id:, service:)

diff --git a/modules/claims_api/app/sidekiq/claims_api/va_notify_declined_job.rb b/modules/claims_api/app/sidekiq/claims_api/va_notify_declined_job.rb
@@ -4,7 +4,7 @@ module ClaimsApi
   class VANotifyDeclinedJob < ClaimsApi::ServiceBase
     LOG_TAG = 'va_notify_declined_job'
 
-    def perform(encrypted_ptcpnt_id:, encrypted_first_name:, representative_id:)
+    def perform(encrypted_ptcpnt_id, encrypted_first_name, representative_id)
       lockbox = Lockbox.new(key: Settings.lockbox.master_key)
       ptcpnt_id = lockbox.decrypt(Base64.strict_decode64(encrypted_ptcpnt_id))
       first_name = lockbox.decrypt(Base64.strict_decode64(encrypted_first_name))

diff --git a/modules/claims_api/spec/sidekiq/va_notify_declined_job_spec.rb b/modules/claims_api/spec/sidekiq/va_notify_declined_job_spec.rb
@@ -32,7 +32,7 @@
                 template_id: Settings.claims_api.vanotify.declined_service_organization_template_id
               })
 
-      subject.perform(encrypted_ptcpnt_id:, encrypted_first_name:, representative_id:)
+      subject.perform(encrypted_ptcpnt_id, encrypted_first_name, representative_id)
     end
   end
 
@@ -62,7 +62,7 @@
                 template_id: Settings.claims_api.vanotify.declined_service_organization_template_id
               })
 
-      subject.perform(encrypted_ptcpnt_id:, encrypted_first_name:, representative_id:)
+      subject.perform(encrypted_ptcpnt_id, encrypted_first_name, representative_id)
     end
   end
 end