Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

824 create 22 1995 confirmation email trigger #12514

Merged
merged 0 commits into from
Jun 1, 2023

Conversation

nhill360
Copy link
Contributor

@nhill360 nhill360 commented May 1, 2023

Summary

  • Includes changes to add trigger for 22-1995 form submission confirmation email.

Related issue(s)

Testing done

  • Modified specs to account for changes.
  • Manually tested changes.

What areas of the site does it impact?

  • Form 1995 submissions.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@nhill360 nhill360 requested review from a team as code owners May 1, 2023 05:18
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 1, 2023 05:24 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 1, 2023 05:25 Inactive
tsr-rise8
tsr-rise8 previously approved these changes May 1, 2023
Copy link
Contributor

@tsr-rise8 tsr-rise8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nhill360 nhill360 requested a review from nathanbwright May 2, 2023 09:41
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 2, 2023 09:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 2, 2023 09:42 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 11, 2023 23:59 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 12, 2023 00:00 Inactive
@nhill360 nhill360 requested a review from nathanbwright May 12, 2023 00:05
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 12, 2023 00:05 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 12, 2023 00:13 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 13, 2023 00:59 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 13, 2023 00:59 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 23, 2023 16:40 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 23, 2023 16:41 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 16:57 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 16:58 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 20:28 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 20:28 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 20:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 25, 2023 20:33 Inactive
Copy link
Contributor

@nathanbwright nathanbwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to match what is shown on the confirmation screen with 100% parity.

Left inline comments on each benefit description that needs to be updated.

Example:
The Fry Scholarship (Chapter 33) to
Fry Scholarship (Chapter 33).

app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
app/models/saved_claim/education_benefits/va_1995.rb Outdated Show resolved Hide resolved
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 16:44 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 16:49 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 17:36 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 17:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 21:43 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 824_create_22-1995_confirmation_email_trigger/main/main May 31, 2023 21:44 Inactive
@nathanbwright nathanbwright merged commit 207be63 into master Jun 1, 2023
@nathanbwright nathanbwright deleted the 824_create_22-1995_confirmation_email_trigger branch June 1, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants