Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vfep 569 - email staging spool files - add emails and update note #12626

Merged
merged 0 commits into from
May 11, 2023

Conversation

GcioGregg
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • Vfep 569 - email staging spool files - add emails and update note
  • (If bug, how to reproduce) N/A
  • (What is the solution, why is this the solution) N/A
  • (Which team do you work for, does your team own the maintainence of this component?) VFEP
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted) N/A

Related issue(s)

  • department-of-veterans-affairs/va.gov-team#0000
  • Link to ticket created in va.gov-team repo
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • rspec, rubocop, developer user tests
  • Describe the steps required to verify your changes are working as expected submit forms on staging and confirm they are in the nightly spool file email sent on staging
  • Describe the tests completed and the results all tests mentioned above passed

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@GcioGregg GcioGregg merged commit 7710259 into master May 11, 2023
@GcioGregg GcioGregg deleted the vfep-569 branch May 11, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants