Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-26270-526-v2-exp-info-pdf-map #12640

Merged
merged 0 commits into from
May 17, 2023
Merged

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented May 12, 2023

Summary

Maps the toxicExposure properties to the 526 PDF Generator (Column C, 526EZ PDF Generator Mapping on Schema Planning Doc):

Related issue(s)

Testing done

  • rspec
  • Postman

What areas of the site does it impact?

modified:   modules/claims_api/config/schemas/v2/526.json
modified:   modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified:   modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified:   modules/claims_api/spec/lib/claims_api/v2/disabilitiy_compensation_pdf_mapper_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels May 12, 2023
@stiehlrod stiehlrod self-assigned this May 12, 2023
@stiehlrod stiehlrod requested review from a team as code owners May 12, 2023 19:48
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 12, 2023 19:51 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 12, 2023 19:59 Inactive
FonzMP
FonzMP previously approved these changes May 12, 2023
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 12, 2023 21:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 12, 2023 21:32 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:09 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:10 Inactive
@stiehlrod stiehlrod marked this pull request as draft May 15, 2023 23:24
@stiehlrod stiehlrod marked this pull request as ready for review May 15, 2023 23:24
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:24 In progress
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:24 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 15, 2023 23:30 Inactive
FonzMP
FonzMP previously approved these changes May 16, 2023
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 17:47 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 17:52 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 18:22 In progress
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 18:23 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 18:34 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 18:35 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 16, 2023 18:57 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 17, 2023 14:25 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26270-526-v2-exp-info-pdf-map/main/main May 17, 2023 14:32 Inactive
FonzMP
FonzMP previously approved these changes May 17, 2023
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@va-vsp-bot va-vsp-bot requested a deployment to API-26270-526-v2-exp-info-pdf-map/main/main May 17, 2023 15:05 In progress
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stiehlrod stiehlrod merged commit ce8da53 into master May 17, 2023
@stiehlrod stiehlrod deleted the API-26270-526-v2-exp-info-pdf-map branch May 17, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants