API-26148-526-v2-pdf-gen-setup

[stiehlrod]

Summary

Sets up connection to 526 PDF Generator service
DVP QA → vets-api Dev
DVP Staging → vets-api Staging
DVP Lab → vets-api Sandbox

Related issue(s)

• API-26148

Testing done

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[mchristiansonVA]

LGTM

[rmtolmach]

I see what Settings.evss.service_name connects to in settings.yaml:

evss:
  prefill: true
  url: https://csraciapp6.evss.srarad.com
  service_name: "wss-form526-services-web"     <--------
  alternate_service_name: "wss-form526-services-web-v2"
  cert_path: ~
  key_path: ~
  root_cert_path: ~
  versions:
    claims: 3.6
    common: 11.6
    documents: 3.7

But I don't see what Settings.dvp.url connects to (nor do I see what Settings.evss.dvp.url used to connect to 🤔)

[rmtolmach]

oh, I see. It looks like you were trying to reference the files in the devops repo: https://github.com/department-of-veterans-affairs/devops/pull/13019/files. Settings. is looking in settings.yaml in the vets-api repo, not the devops repo.

[FonzMP]

but the environment specific .local.yml files get added during the builds, correct? For example, a Firefly engineer added the original dvp url, shown here... and the dev console is showing such. Or is this removed from the build now? I remember a slack message recently saying that maybe only prod is getting the settings file still?

irb(main):001:0> Settings.evss.dvp.url
=> "https://blue.qa.lighthouse.va.gov"

and if that's the case, this PR would make the needed changes to dev, correct? I'm not familiar with the manifest repo, so correct me if I'm wrong.

[stiehlrod]

i was replacing a reference to a setting that we changed in vets-api settings.yml

[rmtolmach]

but the environment specific .local.yml files get added during the builds, correct?

no, not anymore. Everything in this section of values.yaml gets mounted to /app/config/settings.local.yml in the pod. So the reason you're able to see Settings.evss.dvp.url (in a dev pod) is because of the settings defined in the dev values.yaml file. Here's a portion of the settings.local.yml file in a vets-api-prod pod:

nonroot@vets-api-web-5b568b877-4m45b:~$ tail -20 /app/config/settings.local.yml
    aws_access_key_id: <%= ENV['DHP_AWS_ACCESS_KEY_ID'] %>
    aws_secret_access_key: <%= ENV['DHP_AWS_SECRET_ACCESS_KEY'] %>
    region: <%= ENV['DHP_AWS_REGION'] %>
    bucket: <%= ENV['DHP_TOKEN_STORAGE_BUCKET'] %>

dgi:
  jwt:
    public_key_path: /srv/vets-api/secret/production/dgi-prod.crt
    private_key_path: /srv/vets-api/secret/dgi-prod.key
  vets:
    url: <%= ENV['DGI_VETS_URL'] %>

lgy:
  base_url: <%= ENV['LGY_BASE_URL'] %>
  app_id: VAGOVSERVICE
  api_key: <%= ENV['LGY_API_KEY'] %>
  mock_coe: false

dogstatsd:
  enabled: true
nonroot@vets-api-web-5b568b877-4m45b:~$

[rmtolmach]

Does that make sense?
With EKS, the settings get loaded in from the settings-configmap in values.yaml in the manifest repo. settings.yml in vets-api has default values but then the values per environment will get loaded in from the configmap. It's best practice to keep vets-api settings.yml and the configmaps inline even if its blank. So settings.yml needs to have something like this

evss:
  dvp:
    url: ~

[ryan-mcneil]

Looks good now!