Api 26589 v2 itf request format

[rockwellwindsor-va]

Summary

Updates controller and RSpec tests for new request object format.

Related issue(s)

API-26589

Testing done

RSpec

What areas of the site does it impact?

• modules/claims_api/app/controllers/claims_api/v2/veterans/intent_to_file_controller.rb
• modules/claims_api/config/schemas/v2/request_bodies/intent_to_file/example.json
• modules/claims_api/config/schemas/v2/request_bodies/intent_to_file/request.json
• /lib/claims_api/v2/params_validation/intent_to_file/intent_to_file_validator.rb
• modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
• modules/claims_api/spec/requests/v2/veterans/intent_to_files_request_spec.rb
• modules/claims_api/spec/requests/v2/veterans/rswag_intent_to_file_request_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

[ryan-mcneil]

👍 for the extra tests to validate the new, expected format

[aurora-a-k-a-lightning]

lgtm 😄
thank you

[navaeddie]

Sorry, I'm late to this party. But this code looks like it could call .downcase on nil, and crash with a undefined method error?

Looks like you have some tests build around that scenario, so maybe the error is raised before it would crash.

• non-blocking comment, assuming you'll fix it if needed.

[FonzMP]

^ this is possible. if we don't include attributes and only include type (ex: { data: { type: '' }}), it will throw this nil error. i think we could prevent this in a few ways, but maybe updating validate_request_format is the easiest approach? Ultimately, validate_request! should prevent all of this, if I'm understanding correctly.

[FonzMP]