Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[department-of-veterans-affairs/va-virtual-agent#951] Setup flipper for JWT fetching in the front end #12736

Merged
merged 0 commits into from
May 24, 2023

Conversation

aaronyoung-tw
Copy link
Contributor

@aaronyoung-tw aaronyoung-tw commented May 19, 2023

Co-authored-by: Alex Person alex.person@thoughtworks.com

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  1. Create a new flipper with end date May 2024
  2. Add Aaron & Alex as flipper admins

cross referencing this pr from vets-website
Working from the virtual agent team

Related issue(s)

department-of-veterans-affairs/va-virtual-agent#951

  • department-of-veterans-affairs/va.gov-team#0000
  • Link to ticket created in va.gov-team repo
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to master/main/951-add-feature-toggles-for-jwt-retrieval May 19, 2023 15:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 951-add-feature-toggles-for-jwt-retrieval/main/main May 19, 2023 15:44 Inactive
aaronyoung-tw added a commit to department-of-veterans-affairs/vets-website that referenced this pull request May 22, 2023
…retrieve JWT token

   Co-authored-by: Maurice Okumu <maurice.okumu@thoughtworks.com>

1. Add ability to retrieve JWT token
2. Add feature flag / flipper for JWT token
3. fixed a depreciation warning: Module @department-of-veterans-affairs/component-library/LoadingIndicator is deprecated. Use <va-loading-indicator> instead"

cross referencing [this PR](department-of-veterans-affairs/vets-api#12736) in vets-api
@aaronyoung-tw aaronyoung-tw marked this pull request as ready for review May 22, 2023 19:22
@aaronyoung-tw aaronyoung-tw requested review from a team as code owners May 22, 2023 19:22
@va-vsp-bot va-vsp-bot requested a deployment to 951-add-feature-toggles-for-jwt-retrieval/main/main May 24, 2023 14:23 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants