Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 24831 section 5 disabilities validation #12749

Merged
merged 0 commits into from
May 31, 2023
Merged

Api 24831 section 5 disabilities validation #12749

merged 0 commits into from
May 31, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Adds validation and error handling for form 526 v2 disabilities attributes
  • Adds rspec test for added validations
  • Adds new BRD endpoint for /disablities & VCR cassette for testing same

Related issue(s)

API-24831

Testing done

  • Postman
  • rspec

What areas of the site does it impact?

modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels May 19, 2023
@mchristiansonVA mchristiansonVA self-assigned this May 19, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners May 19, 2023 20:05
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 19, 2023 20:12 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 19, 2023 20:18 In progress
@github-actions
Copy link

github-actions bot commented May 19, 2023 •
edited
Loading

1 Error
🚫 This PR changes 745 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+166/-0)

  • modules/claims_api/lib/brd/brd.rb (+4/-0)

  • modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+3/-3)

  • modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+566/-3)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 19, 2023 20:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 22, 2023 13:57 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 22, 2023 13:58 Inactive
stiehlrod
stiehlrod previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 23, 2023 18:28 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 23, 2023 18:28 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 18:48 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 18:49 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 19:04 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 19:04 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 19:31 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 19:32 Inactive
rockwellwindsor-va
rockwellwindsor-va previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Testing done -> RSpec

@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request May 24, 2023
Closed
jeremy6d
jeremy6d previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jeremy6d jeremy6d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 20:52 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 24, 2023 20:52 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 25, 2023 13:14 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 25, 2023 13:15 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 25, 2023 20:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 25, 2023 20:42 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 30, 2023 18:11 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 30, 2023 18:11 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 13:25 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 13:25 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 13:37 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 13:37 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 14:33 In progress
@jeremy6d jeremy6d self-requested a review May 31, 2023 14:48
jeremy6d
jeremy6d previously approved these changes May 31, 2023
View reviewed changes
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 14:49 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 14:52 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24831_Section_5_Disabilities_Validation/main/main May 31, 2023 15:11 In progress
@jeremy6d jeremy6d merged commit a9ac9cb into master May 31, 2023
@jeremy6d jeremy6d deleted the API-24831_Section_5_Disabilities_Validation branch May 31, 2023 15:19
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@mchristiansonVA @jeremy6d
Api 24831 section 5 disabilities validation (#12749)
10630bb 
* Incremental commit

* Fix secondary disability logic

* Add validation for diagnostic code & toxic exposure

* Commit working implementation

* Add VCR cassette for BRD disabilties, add & update disability tests

* Add rspec tests for secondary disabilities

* Rubocop fixes

* Disable module length check

* Fix tests broken by merge

* Move name validation to schema, update tests

* Updates to fix rspec tests, accomodate schema change

* Misc cleanup

* Fix pdf mapper tests

* Fix tests after merge w/ master

* Test updates to add VCR cassette

---------

Co-authored-by: Jeremy Weiland <jeremy6d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwellwindsor-va rockwellwindsor-va rockwellwindsor-va left review comments

@stiehlrod stiehlrod stiehlrod left review comments

@jeremy6d jeremy6d jeremy6d left review comments

@acovrig acovrig Awaiting requested review from acovrig

@FonzMP FonzMP Awaiting requested review from FonzMP

Assignees

@mchristiansonVA mchristiansonVA

Labels
claimsApi modules/claims_api console-services-review Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mchristiansonVA @jeremy6d @stiehlrod @rockwellwindsor-va @va-vfs-bot @va-vsp-bot