Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 24834 section 7 service pay validation #12771

Merged
merged 0 commits into from
May 31, 2023
Merged

Api 24834 section 7 service pay validation #12771

merged 0 commits into from
May 31, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Adds validation and error handling for form 526 v2 service pay attributes
  • Adds rspec test for added validations

Related issue(s)

API-24834

Testing done

  • Postman
  • RSpec

What areas of the site does it impact?

modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels May 23, 2023
@mchristiansonVA mchristiansonVA self-assigned this May 23, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners May 23, 2023 14:48
@github-actions
Copy link

github-actions bot commented May 23, 2023 •
edited
Loading

1 Warning
⚠️ This PR changes 378 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+46/-0)

  • modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+331/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 23, 2023 14:51 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 23, 2023 15:21 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 23, 2023 15:22 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 23, 2023 15:54 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 23, 2023 16:15 Inactive
rockwellwindsor-va
rockwellwindsor-va previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Testing used - RSpec

@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 23, 2023 19:06 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 23, 2023 19:09 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 24, 2023 19:28 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 24, 2023 19:29 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 25, 2023 13:39 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 25, 2023 13:39 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 25, 2023 16:19 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 25, 2023 16:36 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 26, 2023 14:06 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 26, 2023 14:07 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24834_section_7_service_pay_validation/main/main May 30, 2023 17:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24834_section_7_service_pay_validation/main/main May 30, 2023 17:43 Inactive
rockwellwindsor-va
rockwellwindsor-va approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchristiansonVA mchristiansonVA merged commit 6fde0c3 into master May 31, 2023
@mchristiansonVA mchristiansonVA deleted the API-24834_section_7_service_pay_validation branch May 31, 2023 13:25
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@mchristiansonVA
Api 24834 section 7 service pay validation (#12771)
5961d30 
* Incremental commit

* Rubocop fixes

* Test fixes & cleanup

* Disable module length check

* Update context descriptions for updated field names

* Linting fix for quotes

* Remove duplicate module declaration

* Changes for review feedback

* Add generated swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiehlrod stiehlrod stiehlrod left review comments

@rockwellwindsor-va rockwellwindsor-va rockwellwindsor-va approved these changes

@acovrig acovrig Awaiting requested review from acovrig

@FonzMP FonzMP Awaiting requested review from FonzMP

Assignees

@mchristiansonVA mchristiansonVA

Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mchristiansonVA @stiehlrod @rockwellwindsor-va @va-vfs-bot @va-vsp-bot