Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4195-update-endpoint-to-receive-letters-from-lighthouse (part 1) #12774

Merged
merged 0 commits into from
May 23, 2023

Conversation

cadibemma
Copy link
Contributor

Summary

  • Lighthouse has created letter endpoints to replace EVSS. Update letters endpoints to use Lighthouse Letters API. This is part 1 of the PR that only includes specs renaming.

Related issue(s)

Testing done

  • specs

What areas of the site does it impact?

  • None

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@cadibemma cadibemma requested review from a team as code owners May 23, 2023 16:28
@github-actions
Copy link

1 Warning
⚠️ This PR changes 475 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/mobile/spec/request/legacy_letters_request_spec.rb (+328/-0)

  • modules/mobile/spec/request/letters_lighthouse_request_spec.rb (+0/-147)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cadibemma cadibemma merged commit 75bd9cc into master May 23, 2023
@cadibemma cadibemma deleted the 4195-rename-specs branch May 23, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants