Api 24833 526 v2 section 6 service info validation part 2 v2

[rockwellwindsor-va]

Service Information validation - Part 2
Adds validations/tests for service information

Summary

• Adds RSpec tests for validating service information elements for AC points 10 - 21
• Adds methods in validation file for validating service information elements
• Updates 526 schema, and related JSON files, updates with regex for unit numbers (phone, area code)

Related issue(s)

API-24833 - Part 1, AC points 10 - 21

Testing done

RSpec

What areas of the site does it impact?

modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 383 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+62/-0) modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+321/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[ryan-mcneil]

LGTM