Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-26275-526-v2-sec-8-direct-deposit-pdf-mapping #12792

Merged
merged 0 commits into from
May 31, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

Maps direct deposit info for the pdf generator.

Related issue(s)

Testing done

  • rspec
  • Postman

What areas of the site does it impact?

modified:   modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels May 24, 2023
@stiehlrod stiehlrod self-assigned this May 24, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 24, 2023 15:16 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review May 24, 2023 15:25
@stiehlrod stiehlrod requested review from a team as code owners May 24, 2023 15:25
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@va-vsp-bot va-vsp-bot requested a deployment to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 25, 2023 13:37 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 25, 2023 13:38 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 31, 2023 15:12 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 31, 2023 15:33 Inactive
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@va-vsp-bot va-vsp-bot requested a deployment to API-26275-526-v2-sec-8-direct-deposit-pdf-mapping/main/main May 31, 2023 21:57 In progress
@stiehlrod stiehlrod merged commit 8d6add6 into master May 31, 2023
@stiehlrod stiehlrod deleted the API-26275-526-v2-sec-8-direct-deposit-pdf-mapping branch May 31, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants