-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-25894 Save Benefits Intake file sizes #12799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywilliams
added
Lighthouse
lighthouse
appeals
Lighthouse API appeals
banana-peels
Lighthouse Banana Peels Team
labels
May 24, 2023
va-vfs-bot
temporarily deployed
to
API-25984/file-size-metadata/main/main
May 24, 2023 23:52
Inactive
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 24, 2023 23:53
df7a82a
to
ec84ac9
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 24, 2023 23:53
In progress
va-vfs-bot
temporarily deployed
to
API-25984/file-size-metadata/main/main
May 24, 2023 23:58
Inactive
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 25, 2023 00:22
ec84ac9
to
26f5e73
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 25, 2023 00:23
In progress
va-vfs-bot
temporarily deployed
to
API-25984/file-size-metadata/main/main
May 25, 2023 00:23
Inactive
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 25, 2023 00:24
26f5e73
to
90b332e
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 25, 2023 00:24
In progress
caseywilliams
commented
May 25, 2023
@@ -55,6 +55,10 @@ def page_size_inches | |||
} | |||
end | |||
|
|||
def file_size | |||
self['File size'].scan(/\d+/).first.to_i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdfinfo
outputs a File size
string value formatted like "12040 bytes"
, for example
kristen-brown
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me.
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 25, 2023 15:58
90b332e
to
2b6c3f0
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 25, 2023 15:59
In progress
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 25, 2023 17:38
2b6c3f0
to
97a2b42
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 25, 2023 17:39
In progress
caseywilliams
force-pushed
the
API-25984/file-size-metadata
branch
from
May 25, 2023 17:39
97a2b42
to
6d0d3f0
Compare
va-vsp-bot
requested a deployment
to
API-25984/file-size-metadata/main/main
May 25, 2023 17:40
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
appeals
Lighthouse API appeals
banana-peels
Lighthouse Banana Peels Team
console-services-review
Lighthouse
lighthouse
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
VBADocuments::UploadSubmission
s alongside the checksum, page dimensions, etc.Acceptance criteria