API-26710-pdf-mapping-country-code

[stiehlrod]

Summary

Discovery: BRD returns "USA" in the countries list for the US. With that being said, the gem lists it as "United States of America" so it would never locate the United States and be able to provide an alpha2 value. We also see 36 of the 213 retrieved countries fail during lookup using the gem, so it seems that trying to utilize the gem for this scenario is unfortunately not an effective approach.
"Solution": Hardcode the translation for US to be from "USA" to "US" and provide that. If not, send the entire string provided in the request (as long as it aligns with a valid country from BRD).
Reasoning: If the PDF service detects a 2 char code, it will apply it to the Country Code, if it senses anything more, it will apply the entirety of the name to the overflow page.

Related issue(s)

• API-26710

Testing done

• rspec
• Postman

What areas of the site does it impact?

modified:   modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[mchristiansonVA]

LGTM