Api 24835 526 v2 section 8 direct deposit information validation

[rockwellwindsor-va]

Adds direct deposit validation - section 8

Summary

• Adds validataion for direct deposit elements
• Updates 526.json schema file and related files to ensure correct validations
• Updates rswag docs with update schema
• Adds RSpec tests for validations

Related issue(s)

API-24835

Testing done

RSpec

What areas of the site does it impact?

modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

I had to update the schema for the direct deposit object. Specifically one area that could use a heavier glance is the 'accountType' set up. It does pass the tests scenarios and validations but it was the first time I had to use oneOf. I believe I have it correct according to the OAS docs but if someone wants to give that an extra glance it might be worth digging at a little bit just to make sure.

[github-actions]

1 Warning

⚠️

This PR changes 387 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+49/-0) modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+2/-2) modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+334/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[mchristiansonVA]

Typo in example field name...this should be "financialInstitutionName"

[stiehlrod]

Question: What if there is not a value for noAccount?

irb(main):009:0> form_attributes = { "directDeposit"=> { "accountType"=> 'Checking', 'accountNumber'=> '3453425235' } }
=> {"directDeposit"=>{"accountType"=>"Checking", "accountNumber"=>"3453425235"}}
irb(main):010:0> direct_deposit = form_attributes['directDeposit']
=> {"accountType"=>"Checking", "accountNumber"=>"3453425235"}
irb(main):011:0> direct_deposit['noAccount'] == true ? 'yes' : 'no'
=> "no"

[stiehlrod]

I think that is okay, just want to run it by you.

[rockwellwindsor-va]

you're right, it can be more robust, updating that now. It is kind of unintentionally safe. Since we only get to that point if values are present, if 'noAccount' is not present we still go the right place, but looking at the code it would be better to be more intentional on that safeguarding both for the code and for readability by others.