-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused mobile code #12822
remove unused mobile code #12822
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This spec is for appointment scheduling which isn't an active feature. It was using the old parser and old test data to populate data for spec. Had to switch it over to use the newest adapter and test data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New test data using VAOS v2 but manipulated it to match facility ids as needed so I didn't have to rewrite the whole spec
I don't see a lot of benefit in breaking this up into multiple PRs as the mental load in reviewing this is minimal. will ask platform support to make an exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes but nothing to our specs and I assume our specs would catch any accidental deletions. LGTM
Looks good |
Only removing unused code. Large diff acceptable.
Summary
remove unused mobile code
Related issue(s)
department-of-veterans-affairs/va-mobile-app#5744
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?