Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused mobile code #12822

Merged
merged 0 commits into from
May 26, 2023
Merged

remove unused mobile code #12822

merged 0 commits into from
May 26, 2023

Conversation

aherzberg
Copy link
Contributor

Summary

remove unused mobile code

Related issue(s)

department-of-veterans-affairs/va-mobile-app#5744

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@github-actions
Copy link

1 Error
🚫 This PR changes 1549 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/mobile/app/models/mobile/v0/adapters/appointment_requests.rb (+0/-29)

  • modules/mobile/app/models/mobile/v0/adapters/va_appointments.rb (+0/-307)

  • modules/mobile/app/models/mobile/v0/adapters/va_facilities.rb (+0/-61)

  • modules/mobile/app/models/mobile/v0/appointment.rb (+0/-43)

  • modules/mobile/app/models/mobile/v0/templates/base_appointment.rb (+0/-125)

  • modules/mobile/app/models/mobile/v0/templates/community_care_appointment.rb (+0/-45)

  • modules/mobile/app/models/mobile/v0/templates/va_appointment.rb (+0/-45)

  • modules/mobile/spec/models/adapters/appointment_requests_adapter_spec.rb (+0/-349)

  • modules/mobile/spec/models/adapters/va_appointments_adapter_spec.rb (+0/-541)

  • modules/mobile/spec/request/facilities_info_request_spec.rb (+2/-2)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to 5744-remove-mobile-unused-code/main/main May 26, 2023 17:17 Inactive
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec is for appointment scheduling which isn't an active feature. It was using the old parser and old test data to populate data for spec. Had to switch it over to use the newest adapter and test data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test data using VAOS v2 but manipulated it to match facility ids as needed so I didn't have to rewrite the whole spec

@aherzberg aherzberg marked this pull request as ready for review May 26, 2023 17:22
@aherzberg aherzberg requested review from a team as code owners May 26, 2023 17:22
@va-vfs-bot va-vfs-bot temporarily deployed to 5744-remove-mobile-unused-code/main/main May 26, 2023 17:23 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 5744-remove-mobile-unused-code/main/main May 26, 2023 17:23 In progress
@aherzberg
Copy link
Contributor Author

I don't see a lot of benefit in breaking this up into multiple PRs as the mental load in reviewing this is minimal. will ask platform support to make an exception

@va-vfs-bot va-vfs-bot temporarily deployed to 5744-remove-mobile-unused-code/main/main May 26, 2023 17:28 Inactive
Copy link
Contributor

@Tonksthebear Tonksthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes but nothing to our specs and I assume our specs would catch any accidental deletions. LGTM

@jperk51
Copy link
Contributor

jperk51 commented May 26, 2023

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants