Bump fakeredis from 0.8.0 to 0.9.2 #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
va-vsp-bot
requested a deployment
to
dependabot/bundler/fakeredis-0.9.2/main/main
va-vfs-bot
temporarily deployed
to
dependabot/bundler/fakeredis-0.9.2/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/fakeredis-0.9.2/main/main
va-vfs-bot
temporarily deployed
to
dependabot/bundler/fakeredis-0.9.2/main/main
ryan-mcneil
previously approved these changes
May 31, 2023
va-vsp-bot
requested a deployment
to
dependabot/bundler/fakeredis-0.9.2/main/main
ryan-mcneil
reviewed
May 31, 2023
| @@ -78,7 +78,7 @@ def self.pop(redis_key = nil) | |||
| end | |||
|
|
|||
| def self.exists?(redis_key = nil) | |||
| redis_namespace.exists(redis_key) | |||
| redis_namespace.exists?(redis_key) | |||
There was a problem hiding this comment.
fakeredis introduced the exists? method here, so this method was now returning 1 instead of true. Adding the ? gave us passing tests.
Will need to smoke test in staging to confirm it's working as expected
va-vsp-bot
requested a deployment
to
dependabot/bundler/fakeredis-0.9.2/main/main
va-vfs-bot
temporarily deployed
to
dependabot/bundler/fakeredis-0.9.2/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/fakeredis-0.9.2/main/main
ryan-mcneil
added a commit
that referenced
this pull request
Dec 11, 2023
Bumps [fakeredis](https://github.com/guilleiguaran/fakeredis) from 0.8.0 to 0.9.2. - [Commits](guilleiguaran/fakeredis@v0.8.0...v0.9.2) --- updated-dependencies: - dependency-name: fakeredis dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil <ryan.mcneil@oddball.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps fakeredis from 0.8.0 to 0.9.2.
Commits
ba7e3b7Prepare new version of the gem6a11cf2Update homepage for the gemb4bca5aPrepare version 0.9.1f221927Ruby 2.7 was marked as EOL recently, let's keep it in the testing matrix for ...5c163e1[ci skip] Update contributors sections in the README49afc6bRemove unused variable99bbe17Passing the timeout as a positional argument is deprecated, it should be pass...5d9a751Add #sadd? and make #sadd to return an Integer in specsf0d6a81Fix command auth to receive multiple args28a6c19Prepare version 0.9.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)