Forms monitoring - change span to trace to put tag at highest level #12831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a tag to the span and successfully found it in Datadog staging. I noticed that the tag is not easily filterable from the trace menu because it is only associated, not a property of the highest level trace. I want to add it to the trace so that it is easier for my team to filter based on this.
Previous PR to add span tag
Traces consist of one or more spans
You can get active_span or active_trace in ruby
Summary
active_span
getter toactive_trace
to tag at a higher, more filterable levelRelated issue(s)
Testing done
Screenshots
Top level (rack.request) trace and tags
Lower span (rails.action_controller) with added
form_id
tagWhat areas of the site does it impact?
None