Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms monitoring - change span to trace to put tag at highest level #12831

Merged
merged 0 commits into from
May 30, 2023

Conversation

gmrabian
Copy link
Contributor

I added a tag to the span and successfully found it in Datadog staging. I noticed that the tag is not easily filterable from the trace menu because it is only associated, not a property of the highest level trace. I want to add it to the trace so that it is easier for my team to filter based on this.

Previous PR to add span tag

Traces consist of one or more spans
You can get active_span or active_trace in ruby

Summary

  • Change active_span getter to active_trace to tag at a higher, more filterable level

Related issue(s)

Testing done

  • Verified span tag shows up in Datadog. Docs imply this will help bring the tag to the overall trace.

Screenshots

Top level (rack.request) trace and tags
Screenshot 2023-05-30 at 8 13 06 AM

Lower span (rails.action_controller) with added form_id tag
Screenshot 2023-05-30 at 8 13 13 AM

What areas of the site does it impact?

None

@gmrabian gmrabian merged commit 8ba8416 into master May 30, 2023
@gmrabian gmrabian deleted the forms_tag_trace branch May 30, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants