Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-24836-526-v2-sec-9-map-signature #12834

Merged
merged 0 commits into from
Jun 5, 2023

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented May 30, 2023

Summary

  • Adds signature to mapping service

Related issue(s)

Testing done

  • rspec
  • Postman

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modified:   modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
modified:   modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels May 30, 2023
@stiehlrod stiehlrod self-assigned this May 30, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main May 30, 2023 15:59 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24836-526-v2-sec-9-map-signature/main/main May 30, 2023 16:09 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main May 30, 2023 16:10 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24836-526-v2-sec-9-map-signature/main/main June 1, 2023 20:57 In progress
@stiehlrod stiehlrod marked this pull request as ready for review June 1, 2023 21:13
@stiehlrod stiehlrod requested review from a team as code owners June 1, 2023 21:13
@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main June 1, 2023 21:31 Inactive
@stiehlrod stiehlrod marked this pull request as draft June 1, 2023 21:31
@stiehlrod stiehlrod marked this pull request as ready for review June 2, 2023 13:05
@va-vsp-bot va-vsp-bot requested a deployment to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 14:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 14:35 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 14:46 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 14:48 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 15:10 In progress
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@va-vfs-bot va-vfs-bot temporarily deployed to API-24836-526-v2-sec-9-map-signature/main/main June 5, 2023 15:18 Inactive
@stiehlrod stiehlrod merged commit f2581ef into master Jun 5, 2023
@stiehlrod stiehlrod deleted the API-24836-526-v2-sec-9-map-signature branch June 5, 2023 15:19
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Adds test for signature in request spec.

* Rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants