Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-26274_Sec_7_service_pay_pdf_gen #12837

Merged
merged 0 commits into from
Jun 5, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

Maps service pay info for the pdf generator.

Related issue(s)

API-26275

Testing done

  • Postman
  • rSpec

What areas of the site does it impact?

modified: modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels May 30, 2023
@mchristiansonVA mchristiansonVA requested a review from a team as a code owner May 30, 2023 20:00
@mchristiansonVA mchristiansonVA self-assigned this May 30, 2023
@mchristiansonVA mchristiansonVA requested a review from a team as a code owner May 30, 2023 20:00
@va-vfs-bot va-vfs-bot temporarily deployed to API-26274_Sec_7_service_pay_pdf_gen/main/main May 30, 2023 20:13 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26274_Sec_7_service_pay_pdf_gen/main/main May 31, 2023 17:22 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26274_Sec_7_service_pay_pdf_gen/main/main May 31, 2023 17:32 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26274_Sec_7_service_pay_pdf_gen/main/main June 1, 2023 12:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26274_Sec_7_service_pay_pdf_gen/main/main June 1, 2023 12:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-26274_Sec_7_service_pay_pdf_gen/main/main June 2, 2023 13:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-26274_Sec_7_service_pay_pdf_gen/main/main June 2, 2023 13:33 Inactive
@mchristiansonVA mchristiansonVA merged commit 178ba05 into master Jun 5, 2023
@mchristiansonVA mchristiansonVA deleted the API-26274_Sec_7_service_pay_pdf_gen branch June 5, 2023 14:51
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants