Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update form 21-4142 with new pdf #12842

Merged
merged 0 commits into from
May 31, 2023
Merged

Update form 21-4142 with new pdf #12842

merged 0 commits into from
May 31, 2023

Conversation

gmrabian
Copy link
Contributor

New PDF that changes some wording. No impact on form fill.

Summary

  • Replace PDF

Related issue(s)

Testing done

  • Ran tests locally with both versions. Compared generated PDFs side by side and the fill was the same. The only difference is adding the word 'street' to one field prompt.

Screenshots

Old text
Screenshot 2023-05-31 at 9 06 57 AM

New text
Screenshot 2023-05-31 at 9 06 30 AM

What areas of the site does it impact?

none

@gmrabian gmrabian requested review from a team as code owners May 31, 2023 13:07
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request May 31, 2023
Closed
ryan-mcneil
ryan-mcneil approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@gmrabian gmrabian merged commit 15d696c into master May 31, 2023
@gmrabian gmrabian deleted the update-form-214142 branch May 31, 2023 17:41
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@gmrabian
update with new pdf (#12842)
025a64a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmrabian @ryan-mcneil @va-vfs-bot