Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#951] create new route for Virtual Agent JWT proof of concept #12844

Merged
merged 0 commits into from
May 31, 2023

Conversation

aaronyoung-tw
Copy link
Contributor

original issue 951
Co-authored-by: Maurice Okumu maurice.okumu@thoughtworks.com

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • (Summarize the changes that have been made to the platform)
    Created a new route to create a mobile JWT token for the virtual agent team.
    This is a proof of concept and won't be enabled in production, its behind a feature flag.
  • (If bug, how to reproduce)
    n/a
  • (What is the solution, why is this the solution)
    n/a
  • (Which team do you work for, does your team own the maintainence of this component?)
    Virtual Agent Chatbot
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Testing done

testing needs to be done in the staging environment - this is a POC behind a feature flag

  • Describe what the old behavior was prior to the change
    route didn't exist
  • Describe the steps required to verify your changes are working as expected
    We will be testing via postman to see if we get a JWT created in staging
  • Describe the tests completed and the results

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to 951-fetch-jwt-token-poc/main/main May 31, 2023 14:39 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 951-fetch-jwt-token-poc/main/main May 31, 2023 14:43 Inactive
@aaronyoung-tw aaronyoung-tw marked this pull request as ready for review May 31, 2023 14:46
@aaronyoung-tw aaronyoung-tw requested review from a team as code owners May 31, 2023 14:46
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronyoung-tw I won't enforce, as it's a POC, but please note that untested code brings down overall code coverage for the entire repo. So please remember to remove this or create a spec file as you continue to build on it. Thanks!

@aaronyoung-tw aaronyoung-tw merged commit 04d681e into master May 31, 2023
@aaronyoung-tw aaronyoung-tw deleted the 951-fetch-jwt-token-poc branch May 31, 2023 18:08
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* [#951] create new route for Virtual Agent JWT proof of concept

[original issue 951](https://github.com/department-of-veterans-affairs/va-virtual-agent/issues/951)
   Co-authored-by: Maurice Okumu <maurice.okumu@thoughtworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants