Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#951] Refactor the Virtual Agent JWT fetch code to use a helper class. #12859

Merged
merged 0 commits into from
Jun 1, 2023

Conversation

aaronyoung-tw
Copy link
Contributor

@aaronyoung-tw aaronyoung-tw commented Jun 1, 2023

Co-authored-by: Maurice Okumu maurice.okumu@thoughtworks.com

Summary

We refactored the Virtual Agent JWT fetch POC code to allow for the extending of the common::client::base

  • (Which team do you work for, does your team own the maintainence of this component?)
    Virtual Agent Chatbot team

Related issue(s)

department-of-veterans-affairs/va-virtual-agent#951

Testing done

Tested locally but we need to continue testing in staging - this feature is behind a flipper which won't make it to production. As before we didn't create a spec file as this will be a short-term POC (under a week) we intend on cleaning up.

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
    Hit the endpoint with postman using the appropriate headers/cookies and getting a returned JWT
  • Describe the tests completed and the results
    Getting a 403 from an endpoint as we are not behind the VA network to continue testing locally

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 951-fetch-jwt-token-poc/main/main June 1, 2023 15:39 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 951-fetch-jwt-token-poc/main/main June 1, 2023 15:41 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 951-fetch-jwt-token-poc/main/main June 1, 2023 15:44 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 951-fetch-jwt-token-poc/main/main June 1, 2023 18:10 In progress
@va-vsp-bot va-vsp-bot requested a deployment to 951-fetch-jwt-token-poc/main/main June 1, 2023 18:13 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 951-fetch-jwt-token-poc/main/main June 1, 2023 18:13 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 951-fetch-jwt-token-poc/main/main June 1, 2023 20:06 In progress
@@ -1081,7 +1081,8 @@ va_mobile:
url: "https://veteran.apps.va.gov"
ppms_base_url: "https://staff.apps.va.gov"
mock: false
key_path: /fake/client/key/path
# key_path: /fake/client/key/path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this unintentionally commited file and also cleaned out other dead code

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@aaronyoung-tw aaronyoung-tw merged commit 06d8fbf into master Jun 1, 2023
@aaronyoung-tw aaronyoung-tw deleted the 951-fetch-jwt-token-poc branch June 1, 2023 21:01
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
…s. (#12859)

* [#951] Refactor the Virtual Agent JWT fetch code to use a helper class.
[department-of-veterans-affairs/va-virtual-agent#951]

   Co-authored-by: Maurice Okumu <maurice.okumu@thoughtworks.com>

We refactored the code to allow for the extending of the
common::client::base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants