-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#951] Refactor the Virtual Agent JWT fetch code to use a helper class. #12859
Conversation
config/settings.yml
Outdated
@@ -1081,7 +1081,8 @@ va_mobile: | |||
url: "https://veteran.apps.va.gov" | |||
ppms_base_url: "https://staff.apps.va.gov" | |||
mock: false | |||
key_path: /fake/client/key/path | |||
# key_path: /fake/client/key/path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this unintentionally commited file and also cleaned out other dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Co-authored-by: Maurice Okumu maurice.okumu@thoughtworks.com
Summary
We refactored the Virtual Agent JWT fetch POC code to allow for the extending of the common::client::base
Virtual Agent Chatbot team
Related issue(s)
department-of-veterans-affairs/va-virtual-agent#951
Testing done
Tested locally but we need to continue testing in staging - this feature is behind a flipper which won't make it to production. As before we didn't create a spec file as this will be a short-term POC (under a week) we intend on cleaning up.
Hit the endpoint with postman using the appropriate headers/cookies and getting a returned JWT
Getting a 403 from an endpoint as we are not behind the VA network to continue testing locally
Acceptance criteria