Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5103 endpoint to benefits_claims controller #12862

Merged
merged 0 commits into from
Jun 2, 2023

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Jun 1, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Adding a new endpoint to the benefits_claims controller for 5103 submission

  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintainence of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Testing done

Added new specs / vcr cassettes for the new endpoint

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this Jun 1, 2023
@va-vsp-bot va-vsp-bot requested a deployment to 59279-add-5103-endpoint/main/main June 1, 2023 18:43 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59279-add-5103-endpoint/59279-add-5103-endpoint/main June 1, 2023 18:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 59279-add-5103-endpoint/59279-add-5103-endpoint/main June 1, 2023 18:56 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59279-add-5103-endpoint/main/main June 1, 2023 19:09 In progress
@va-vsp-bot va-vsp-bot requested a deployment to 59279-add-5103-endpoint/main/main June 1, 2023 19:12 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59279-add-5103-endpoint/59279-add-5103-endpoint/main June 1, 2023 19:21 Inactive
@jerekshoe jerekshoe marked this pull request as ready for review June 1, 2023 20:15
@jerekshoe jerekshoe requested review from a team as code owners June 1, 2023 20:15
@va-vsp-bot va-vsp-bot requested a deployment to 59279-add-5103-endpoint/main/main June 1, 2023 20:18 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59279-add-5103-endpoint/59279-add-5103-endpoint/main June 1, 2023 20:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59279-add-5103-endpoint/main/main June 2, 2023 17:43 In progress
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerekshoe jerekshoe merged commit 3a80303 into master Jun 2, 2023
@jerekshoe jerekshoe deleted the 59279-add-5103-endpoint branch June 2, 2023 18:17
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Adding 5103 endpoint to benefits_claims controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants