Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

its honest work #12879

Merged
merged 0 commits into from
Jun 5, 2023
Merged

its honest work #12879

merged 0 commits into from
Jun 5, 2023

Conversation

FonzMP
Copy link
Contributor

@FonzMP FonzMP commented Jun 2, 2023

Summary

  • The VA Gov CST Team experienced a 500 and contacted us in regards. Looks like it's calling .find on a nil and failing. to bypass this, we can simply set it to an empty array so if it doesn't make it to the later phase of setting supporting documents to doc['documents'] it won't throw the error. I contemplated doing this down at the return, but rubocop threw a MethodLength error so I just elected to set it in a single line.

Related issue(s)

  • VA Gov reported.

Testing done

  • Local testing.

What areas of the site does it impact?

Claims V2 show

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@FonzMP FonzMP added the claimsApi modules/claims_api label Jun 2, 2023
@FonzMP FonzMP requested review from a team as code owners June 2, 2023 19:58
@va-vsp-bot va-vsp-bot requested a deployment to claims_api_nil_supporting_docs/main/main June 2, 2023 20:00 In progress
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heavy lift!

@va-vfs-bot va-vfs-bot temporarily deployed to claims_api_nil_supporting_docs/main/main June 2, 2023 20:09 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to claims_api_nil_supporting_docs/main/main June 5, 2023 14:58 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to claims_api_nil_supporting_docs/main/main June 5, 2023 15:05 Inactive
@FonzMP FonzMP merged commit 78121ff into master Jun 5, 2023
@FonzMP FonzMP deleted the claims_api_nil_supporting_docs branch June 5, 2023 15:09
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants