Update demographics policy to match business rules #12890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
update-demographics-policy-to-match-business-rules/main/main
This was referenced Jun 5, 2023
|
LGTM |
va-vsp-bot
requested a deployment
to
update-demographics-policy-to-match-business-rules/main/main
aherzberg
previously approved these changes
Jun 8, 2023
| @@ -37,7 +38,7 @@ | |||
| it 'returns a 201' do | |||
| gender_identity = VAProfile::Models::GenderIdentity.new(code: 'F') | |||
|
|
|||
| VCR.use_cassette('mobile/va_profile/post_gender_identity_success') do | |||
| VCR.use_cassette('mobile/va_profile/post_gender_identity_success', erb: { csd: }) do | |||
There was a problem hiding this comment.
Cool way to customize VCRS. we should be doing more of that.
va-vfs-bot
temporarily deployed
to
update-demographics-policy-to-match-business-rules/main/main
va-vsp-bot
requested a deployment
to
update-demographics-policy-to-match-business-rules/main/main
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Update demographics_policy.rb * updated doc wording to be accurate * Update tests to be compatible with updated policy * Copy master index.html to branch * rerender docs --------- Co-authored-by: Tonksthebear <jasonconig@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
After some discussions in slack we have decided the original implementation of this policy was correct so we are reverting it to match that decision.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#5776
Testing done
Updated tests to allow the returning of uuids
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?