Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 27055 null vet icn v2 526 #12895

Merged
merged 0 commits into from
Jun 7, 2023
Merged

Api 27055 null vet icn v2 526 #12895

merged 0 commits into from
Jun 7, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Adds handling for case where 526 endpoint is called with nil veteran ICN parameter.

Related issue(s)

API-27055

Testing done

  • Postman
  • rspec

What areas of the site does it impact?

/modules/claims_api/app/models/claims_api/veteran.rb
/modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Jun 5, 2023
@mchristiansonVA mchristiansonVA self-assigned this Jun 5, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners June 5, 2023 20:06
@va-vfs-bot va-vfs-bot temporarily deployed to API-27055_null_Vet_ICN_v2_526/main/main June 5, 2023 20:18 Inactive
rockwellwindsor-va
rockwellwindsor-va approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

stiehlrod
stiehlrod approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using Postman

@mchristiansonVA mchristiansonVA merged commit 1a3f708 into master Jun 7, 2023
@mchristiansonVA mchristiansonVA deleted the API-27055_null_Vet_ICN_v2_526 branch June 7, 2023 18:03
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@mchristiansonVA
Api 27055 null vet icn v2 526 (#12895)
fe4f9c9 
* Add before_action for CCG

* Add nil-safing to mpi_record

* Add rspec test

* Remove byebug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwellwindsor-va rockwellwindsor-va rockwellwindsor-va approved these changes

@stiehlrod stiehlrod stiehlrod approved these changes

@acovrig acovrig Awaiting requested review from acovrig

@FonzMP FonzMP Awaiting requested review from FonzMP

Assignees

@mchristiansonVA mchristiansonVA

Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mchristiansonVA @stiehlrod @rockwellwindsor-va @va-vfs-bot